Redirect Firefox system requirements to Bedrock #2053
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
||
| # bug 1001238 | ||
| RewriteRule ^/(en-US/)?firefox/(24\.[5678]\.\d)/(releasenotes|system-requirements)(/)?$ /b/$1firefox/$2/$3$4 [PT] |
There was a problem hiding this comment.
I think that instead of removing this line entirely, we should change it to
RewriteRule ^/(en-US/)?firefox/(24\.[5678]\.\d)/releasenotes(/)?$ /b/$1firefox/$2/releasenotes$3 [PT]
|
Other than the one correction, this lgtm, but I think we should put this on a demo server for further testing. @sgarrity can you do that, or would you like me to? |
|
This is now up on demo5. Example: https://www-demo5.allizom.org/en-US/firefox/10.0/system-requirements/ |
|
I finally got mcom-tests running locally with saucelabs against demo5; looks good! |
jgmize
added a commit
that referenced
this pull request
Jun 1, 2014
Redirect Firefox system requirements to Bedrock
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bug 957242
ATTN: @pmclanahan @jgmize
I'm not able to test this locally - please have a close look at this.