Change download buttons to point to /firefox/new/

[sgarrity]

Download links will point to the second scene of download page
with the url fragment /firefox/new/#download-fx
Bug 874913

[sgarrity]

After discussing on the phone: I need to check with l10n that the settings.LOCALES_WITH_TRANSITION list is relevant to the /firefox/new page, and not only the old products/download.html page.

[flodolo]

It's not completely relevant: LOCALES_WITH_TRANSITION has several locales (bn-BD, bn-IN, si, to name a few) that are not enabled for /firefox/new because the page has never been localized.

On the other hand, is missing locales that we added lately (az, dsb, etc.).

[sgarrity]

Here's a quick summary of our discussion on vidyo today:

The ye-olde PHP-based buttons used to do client-side locale detection and output a download link for that locale (either direct, or through the old transition page).

The /firefox/new/ page download does not do client-side locale detection except to redirect to /LOCALE/firefox/new if there is no locale in the URL.

There are locales in which Firefox is available for download that the /firefox/new page is NOT available in. See http://l10n.mozilla-community.org/~pascalc/langchecker/?locale=all&website=0&file=firefox/new.lang

As a result, if this PR were to land as is, and a visitor had a locale that was not enabled for /firefox/new, they would have to manually choose the Systems & Languages link.

I wondered if we should "enable" ALL locales for /firefox/new/ and consider the download button strings (at least) as a requirement to ship Firefox in a given locale.

Keeping these code pathes simple, understandable, and testable is key, given how important the download process is.

@jgmize also aptly suggested that we get QA testing this as soon as possible.

[jgmize]

I submitted #2215 to enable all locales on bedrock for /firefox/new

[jgmize]

@sgarrity once you have Jenkins passing will you please put this on one of the demo environments?

[sgarrity]

@jgmize @pmclanahan @flodolo So, if we enable all locales for /firefox/new/ as per PR #2215, is the LOCALES_WITH_TRANSITION list still relevant? See:

bedrock/bedrock/settings/base.py

Line 869 in f9f9100

# Locals with transitional download pages

I wondered if it might make sense to send all downloaders, regardless of locale, to /firefox/new/#download-fx - even if they would see an en-US post-download page.

Also, does PR #2215 affect whether or not the locale should be in the '/{locale}/firefox/new/#download-fx' URL?

[pmclanahan]

@jgmize @pmclanahan @flodolo So, if we enable all locales for /firefox/new/ as per PR #2215, is the LOCALES_WITH_TRANSITION list still relevant? See:

bedrock/bedrock/settings/base.py

Line 869 in f9f9100

# Locals with transitional download pages

I think that's more a question for @pascalchevrel and possibly UX.

I wondered if it might make sense to send all downloaders, regardless of locale, to /firefox/new/#download-fx - even if they would see an en-US post-download page.

That sounds fine to me. Others might disagree.

Also, does PR #2215 affect whether or not the locale should be in the '/{locale}/firefox/new/#download-fx' URL?

I don't think so.

[jgmize]

+1 for getting rid of LOCALES_WITH_TRANSITION

I wondered if it might make sense to send all downloaders, regardless of locale, to /firefox/new/#download-fx - even if they would see an en-US post-download page.

Makes sense to me.

Also, does PR #2215 affect whether or not the locale should be in the '/{locale}/firefox/new/#download-fx' URL?

Seems like we should send them to the URL without the locale to me.

[sgarrity]

Moving the discussion over to Bugzilla with a needsinfo for Pascal: https://bugzilla.mozilla.org/show_bug.cgi?id=874913#c17

[sgarrity]

Ok, we got some helpful feedback over on the bug. This PR now removes the LOCALES_WITH_TRANSITION and removes the local from the transition download page URL.

There are a bunch of download tests failing now, but I'm not sure I know how to deal with all of them. @jgmize Could I get a hand with those? Some may be obsolete, and other new tests may be warranted, but I just don't have the experience with python or bedrock tests to determine that myself. A few of them, at least, were testing for LOCALE in the download URL, which isn't relevant anymore (though those tests could be modified to still test the force_direct=true variation).

[jgmize]

@sgarrity sure, I'll take on fixing the tests and push the results to a branch on the mozilla repo and put it on a demo server.

[sgarrity]

@jgmize has a better PR with these changes over in PR #2221.