[fix bug 1045961] Add larger icons to homepage #2331
Conversation
|
Thanks @ckprice! Reading back through the bug, I think we can simplify what you have here a bit. For iOS, I think we're safe to include a single Secondly, because of the Firefox OS bug whereby the last icon declared is always chosen (irrespective of size), we could either consider reversing the order of Note: you will also need to make this change to Thanks! |
| @@ -34,6 +34,8 @@ | |||
| <meta name="twitter:app:name:googleplay" content="{% block android_app_name %}{{ _('Firefox') }}{% endblock %}"> | |||
| <meta name="twitter:app:id:googleplay" content="{% block android_app_id %}org.mozilla.firefox{% endblock %}"> | |||
| <link rel="shortcut icon" href="{% block page_favicon %}{{ media('img/favicon.ico') }}{% endblock %}"> | |||
| <link rel="apple-touch-icon" sizes="180x180" href="{{ media('img/favicon/apple-touch-icon-180x180.png') }}"> | |||
| <link rel="icon" type="image/png" href="{{ media('img/favicon/favicon-196x196.png') }}" sizes="196x196"> | |||
There was a problem hiding this comment.
Nit: can we move the sizes attribute here to immediately before the href, so that it's more consistent with the apple-touch-icon ordering? Same applies to base.html
|
If you run both these new icons through imageoptim we can save around 80% on the file size. |
|
Tested this on iOS and Firefox OS 2.2.0 and I see appropriately sized icons for each when added to home screen 👍 It's an r+wc from me - just a couple of things to tidy up, then if you can squash commits I think we're good to merge this. |
ckprice
force-pushed
the
bug-1045961-homescreen-icons
branch
from
daa3c6c
to
4a2a2a4
Compare
|
Thanks @alexgibson! Updates made. |
|
r+ |
[fix bug 1045961] Add larger icons to homepage
Bug: https://bugzilla.mozilla.org/show_bug.cgi?id=1045961
Created new icons for mobile "Add to homescreen" integration.