Bug 1125971 - Fixing quotes on /fr/privacy/tips/ and removing extra spac... #2681
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@jpetto Mind giving it a quick look when you have the opportunity? |
|
I've given this a quick check over and looks fine, thanks @TheoChevalier :) Only nit is the comment hack to remove the extra white space. This seems to work fine, but I think it might confuse people to see it there in the markup. Perhaps a simpler solution might just to be to inline the content between the |
…pace before the closing quotation mark
TheoChevalier
force-pushed
the
privacy-day-tips-fix-french
branch
from
58dec90
to
d71cc75
Compare
|
Thanks Alex! |
|
LGTM, thanks @TheoChevalier r+ 🎱 |
alexgibson
added a commit
that referenced
this pull request
Jan 30, 2015
Bug 1125971 - Fixing quotes on /fr/privacy/tips/ and removing extra spac...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
...e before the closing quotation mark
the are here to remove the extra space between the string and the closing quotation mark. That's a bit of a hack, let me know if you think of something cleaner ;)