Fix Bug 1131304 - Add share buttons to 'Download Firefox in your language' page #2774
Conversation
|
We should probably also add |
| @@ -1,5 +1,7 @@ | |||
| {% extends "firefox/base-resp.html" %} | |||
|
|
|||
| {% set num_languages = settings.CONTRIBUTE_NUMBERS.num_languages|round(-1, 'floor')|int %} | |||
There was a problem hiding this comment.
Hmm... is this supposed to round 87 down to 80? Any reason not just go for a more exact figure if we're pulling the same data that's on both the homepage and /contribute?
|
Ping @flodolo - new strings for share CTA on |
| html[dir="rtl"] #masthead h2 { | ||
| float: right; | ||
| margin: 0 auto; | ||
| width: @widthDesktop - @gridGutterWidth*2; |
There was a problem hiding this comment.
Nit: (@gridGutterWidth * 2) for consistency
|
I don't imaging this will cause a conflict, but the only other thing we should check on before merging this is for any impact on the new Firefox Family Navigation that is currently in development. @jpetto - do you see any issues here or reason's to hold off merging this change? I assume it could only impact the Hello product page? |
|
We're flooding localizers with requests :-\ How many of requests of this kind do we have still pending? |
| {% if channel == 'release' -%} | ||
| {% set share_urls = { 'twitter': 'http://mzl.la/1IMdR5T', 'googleplus': 'http://mzl.la/1y7TgOf', 'facebook': 'http://mzl.la/1ATF965' } -%} | ||
| {% if l10n_has_tag('share_cta') -%} | ||
| {% set share_text = _('Thanks to contributions of Mozilla community members around the world, Firefox is available in %s languages:')|format(num_languages) %} |
There was a problem hiding this comment.
This is not going to work for a lot of locales (languages need to be adapted to the actual number).
We had the same issue in the past, and ended up using "in more than X languages" (not sure what X is these days).
There was a problem hiding this comment.
And now that I realize it, we're not actually localizing this page (maybe just for Japanese), but worth fixing anyway.
There was a problem hiding this comment.
Then let's use a static number and I'll update the Japanese copy. X = 80 according to the bug.
Here’s another optimization. Add the new `site_header_share` block to put the button in `#masthead`.
|
Solved issues @alexgibson and @flodolo noted. |
| @@ -13,7 +13,7 @@ | |||
| {% elif channel == 'esr' %} | |||
| {{ _('Firefox ESR is intended for groups who deploy and maintain the desktop environment in large organizations. <a href="%s">Learn more.</a>')|format(url('firefox.organizations.organizations')) }} | |||
| {% else %} | |||
| {{ _('Firefox is available in more than %s languages thanks to the contributions of Mozilla community members from around the world.')|format('80') }} | |||
| {{ _('Firefox is available in more than 80 languages thanks to the contributions of Mozilla community members from around the world.') }} | |||
There was a problem hiding this comment.
If we're no longer changing this, why hard-code the value instead of allow us to change it in the future without breaking the string?
There was a problem hiding this comment.
Ah, i missed @flodolo's comment, never mind 👍
|
Teeny nit: focus styling could be improved a little. I'm all for leaving a dotted focus outline, but it should probably not be cropped at the top/bottom.
|
|
The Firefox Family nav will replace the entire There's really no reason to hold off on merging this PR, though it's possible only 1 of the 4 pages updated here will retain the |
Thanks for the heads-up @jpetto - sounds like we'll have to work out where to re-position the sharing widget on these pages after 3/12 😢 @kyoshino - could you please feed this info back to whoever is managing these social sharing updates? Many thanks. |
|
Then it might be better to postpone this change. Asked in the bug if it's okay. |
|
:williamr in the bug says we can wait until March. |
|
@kyoshino - as Jen said, we are happy to merge this PR and then revisit later this month. unless you would rather wait? |
|
Then |
👍
Fix Bug 1131304 - Add share buttons to 'Download Firefox in your language' page
Here’s another optimization. Introducing the new
site_header_shareblock to put the button in#masthead. The change will affect the existing /firefox/hello/ and /plugincheck/ pages.This /firefox/all/ page has been localized into Japanese only and we have almost the same fallback text, so this is good to go.
I have added one more button for /firefox/developer/ because the change is small and similar. This time again, the existing copy will be used as the l10n fallback.
@alexgibson r?