Bug 1133004. Fx family landing page. #2827
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jpetto
force-pushed
the
bug-1133004-fx-family-portal-page
branch
from
861f497
to
d6f0513
Compare
craigcook
force-pushed
the
bug-1133004-fx-family-portal-page
branch
5 times, most recently
from
34332bf
to
79b9a5c
Compare
|
Still to do:
The RTL work could be punted to post-launch since it doesn't look like it's yet localized in ar, fa, or he. |
| 'firefox_family': { | ||
| 'source_filenames': ( | ||
| 'css/sandstone/sandstone-resp.less', | ||
| 'css/firefox/family-nav.less', |
craigcook
force-pushed
the
bug-1133004-fx-family-portal-page
branch
2 times, most recently
from
3381785
to
270d12f
Compare
| var latestFirefoxVersionFull = $html.attr('data-latest-firefox'); | ||
|
|
||
| // get latest full version (no point release info) for initial check | ||
| var latestFirefoxVersion = parseInt(latestFirefoxVersionFull.split('.')[0], 10); |
There was a problem hiding this comment.
Is needed? Looks like isFirefoxUpToDate() already handles much of the logic
There was a problem hiding this comment.
Probably not needed. I swiped this from firefox/new.js which has a lot of extra conditional bits of logic, but I think this is redundant for this page.
|
Let's not forget to show Tabzilla the door on this page also 👍 |
craigcook
force-pushed
the
bug-1133004-fx-family-portal-page
branch
from
270d12f
to
c066003
Compare
craigcook
changed the title
craigcook
force-pushed
the
bug-1133004-fx-family-portal-page
branch
3 times, most recently
from
6c16f2c
to
1b9b0af
Compare
Remove the old products page Update links in Tabzilla
craigcook
force-pushed
the
bug-1133004-fx-family-portal-page
branch
from
1b9b0af
to
e26b51f
Compare
| $('.product-list').on('click', 'a', function(e) { | ||
| var newTab = ($(this).target === '_blank' || e.metaKey || e.ctrlKey); | ||
| var href = $(this).attr('href'); | ||
| var product = $(this).data('product'); |
There was a problem hiding this comment.
Looks like this var isn't used?
There was a problem hiding this comment.
Oops, should be passing the product name in place of the href. Fixed!
|
Aside from small JS nits above and 1400px wide intro/heading styles, things are looking good. |
IE9 crashes when calc() is used for background position Also reworked media queries to 1000px is the base width
craigcook
force-pushed
the
bug-1133004-fx-family-portal-page
branch
from
e26b51f
to
edb9107
Compare
|
Looking good! r+ 🍝 |
jpetto
added a commit
that referenced
this pull request
Mar 31, 2015
Bug 1133004. Fx family landing page.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.