Add certs to bedrock: bug 1149019 #3847
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Fixes #3844 |
|
@pmclanahan r? |
|
Looks good, but the files should be in |
| @@ -12,11 +12,13 @@ class BedrockWhiteNoise(DjangoWhiteNoise): | |||
| def __init__(self, application): | |||
| super(BedrockWhiteNoise, self).__init__(application) | |||
|
|
|||
| # TODO add tests for these in mcom-tests | |||
| # TODO add functional tests for these | |||
There was a problem hiding this comment.
flake8 doesn't like the trailing whitespace on the comment :( seems a bit picky, but okay.
|
Move the files and fix flake8 and we're good. Thanks! |
Thanks @pmclanahan, good catch on the dir. I've fixed that and removed the trailing space in 6edb8a8 |
pmclanahan
added a commit
that referenced
this pull request
Feb 11, 2016
Add certs to bedrock: bug 1149019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.