Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[bug 1248040] Update GTM data attributes missed on first pass through #4026

Merged
merged 1 commit into from
Apr 4, 2016
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
2 changes: 1 addition & 1 deletion bedrock/base/templates/includes/site-footer.html
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
<footer id="colophon" class="{% block footer_class %}{% endblock %}">
<nav class="row">
<div class="col col-1">
<h1 class="logo"><a href="{{ url('mozorg.home') }}">Mozilla</a></h1>
<h1 class="logo"><a href="{{ url('mozorg.home') }}" data-link-type="footer" data-link-name="Mozilla">Mozilla</a></h1>
<p class="license">
{%- trans url=url('foundation.licensing.website-content') -%}
Portions of this content are ©1998–{{ current_year }} by individual
Expand Down
2 changes: 1 addition & 1 deletion bedrock/base/templates/macros.html
Original file line number Diff line number Diff line change
Expand Up @@ -284,7 +284,7 @@ <h3>{{ cta_text }}</h3>
{# Page will dictate CTA (button, usually) to be placed in this wrapper #}
<div id="fxfamilynav-cta-wrapper" class="fxfamilynav-cta-wrapper">{% if caller %}{{ caller() }}{% endif %}</div>

<button type="button" id="fxfamilynav-tertiarynav-trigger" class="fxfamilynav-tertiarynav-trigger" aria-controls="fxfamilynav-tertiarynav" data-link-type="nav" data-link-name="Open Side Menu">
<button type="button" id="fxfamilynav-tertiarynav-trigger" class="fxfamilynav-tertiarynav-trigger" aria-controls="fxfamilynav-tertiarynav">
<span>{{ _('Menu') }}</span>
<div class="trigger-dots">
<div class="trigger-dot"></div>
Expand Down
2 changes: 1 addition & 1 deletion bedrock/firefox/templates/firefox/choose.html
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,7 @@
{% block alt_header %}
<div class="header-content">
<div id="tabzilla">
<a href="{{ url('mozorg.home') }}">Mozilla</a>
<a href="{{ url('mozorg.home') }}" data-link-type="nav" data-link-name="tabzilla">Mozilla</a>
</div>
<h1>{{ high_res_img('firefox/choose/header-firefox.png', {'alt': 'Firefox', 'width': '223', 'height': '84'}) }}</h1>

Expand Down
2 changes: 1 addition & 1 deletion bedrock/firefox/templates/firefox/family/index.html
Original file line number Diff line number Diff line change
Expand Up @@ -56,7 +56,7 @@
{% block tabzilla_tab %}
<div class="content">
<div id="tabzilla">
<a href="{{ url('mozorg.home') }}">Mozilla</a>
<a href="{{ url('mozorg.home') }}" data-link-type="nav" data-link-name="tabzilla">Mozilla</a>
</div>
</div>
{% endblock %}
Expand Down
6 changes: 3 additions & 3 deletions bedrock/mozorg/templates/mozorg/home/home.html
Original file line number Diff line number Diff line change
Expand Up @@ -326,19 +326,19 @@ <h4>{{_('Committed to <strong>you, your privacy</strong> and an <strong>open Web
<div class="container">
<ul>
<li>
<a class="add-ons" rel="external" href="https://addons.mozilla.org/" data-element-location="Secondary Link Clicks" data-link-type="href">
<a class="add-ons" rel="external" href="https://addons.mozilla.org/">
<h2>{{ _('Add-ons') }}</h2>
<p>{{ _('Compare prices, check the weather, listen to music, send a tweet and more right from Firefox.') }}</p>
</a>
</li>
<li>
<a class="careers" rel="external" href="https://careers.mozilla.org/" data-element-location="Secondary Link Clicks" data-link-type="href">
<a class="careers" rel="external" href="https://careers.mozilla.org/">
<h2>{{ _('Careers') }}</h2>
<p>{{ _('Learn about the benefits of working at Mozilla and view open positions around the world.') }}</p>
</a>
</li>
<li>
<a class="help" rel="external" href="https://support.mozilla.org/" data-element-location="Secondary Link Clicks" data-link-type="href">
<a class="help" rel="external" href="https://support.mozilla.org/">
<h2>{{ _('Need help?') }}</h2>
<p>{{ _('Get answers to your questions about Firefox and all Mozilla products from our support team.') }}</p>
</a>
Expand Down
11 changes: 1 addition & 10 deletions media/js/firefox/family-nav.js
Original file line number Diff line number Diff line change
Expand Up @@ -57,9 +57,7 @@ if (typeof window.Mozilla === 'undefined') {

if ($tertiaryNavTrigger.hasClass('active')) {
window.dataLayer.push({
'event': 'family-nav-interaction',
'location': 'Side Menu',
'browserAction': 'Open Menu'
'event': 'open-side-menu'
});
}
}).addClass('visible');
Expand Down Expand Up @@ -122,13 +120,6 @@ if (typeof window.Mozilla === 'undefined') {
}
};

$tertiaryNavs.on('click', 'a', function() {
window.dataLayer.push({
'event': 'family-nav-interaction',
'browserAction': $(this).attr('data-ga')
});
});

// public interface
return {
init: function() {
Expand Down