Import Tabzilla into Bedrock #507
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| import l10n_utils | ||
|
|
||
|
|
||
| def tabzilla_js(request): |
There was a problem hiding this comment.
You should probably add a cache decorator to get zeus to cache this for some amount of time to avoid extra load.
There was a problem hiding this comment.
All our HTTP requests are cached 10 minutes by default.
|
r+ for what's here. The LESS variable is a nice-to-have and we could live with an added step to the docs if you're strapped for time. Let me know when you add the other stuff so I can finish the review. :D |
|
r+ |
|
Pull request updated with documentation imported. |
|
|
||
| *tabzilla* is the universal tab displayed on Mozilla websites. | ||
|
|
||
| Adding the universal tab requires to a site requires: |
|
r+ looks good to me |
- Make it localisable - Add redirects for backwards compatibility - Adds a js_escape filter bug 744271
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm submitting this to get the code approved. Do not merge yet ;)
Things left to do:
tabzilla/media/js/tabzilla.js,tabzilla/media/css/tabzilla.cssandtabzilla/tabzilla.js.