Fix Bug 1430027 - On the download page, for Linux, highlight the 64-bit version (to limit the number of 32 downloads) #5432
Conversation
I see they're not from the bug. Given that we can't use tags, the sooner we agree on the text and expose it for translation, the better. We should also keep the PR on hold for a few days, to allow at least the top locales to catch up. |
kyoshino
force-pushed
the
demo/firefox-all
branch
from
cb2b369
to
6e65719
Compare
|
@flodolo based on the discussion in the bug, Legacy won't be used and only Recommended will be added as a new string. |
kyoshino
force-pushed
the
demo/firefox-all
branch
from
6e65719
to
19c02fb
Compare
Thanks, extracting that string then. |
|
@flodolo are we good now with l10n coverage? |
|
Yes, I think we're good (also, cc @peiying2) |
| @@ -341,7 +353,7 @@ class FirefoxAndroid(_ProductDetails): | |||
| 'x86': archive_url_base + '-%s/fennec-%s.multi.android-i386.apk', | |||
| } | |||
|
|
|||
| def platforms(self, channel='release'): | |||
| def platforms(self, channel='release', classified=False): | |||
There was a problem hiding this comment.
Could we add a comment here explaining why this method has an unused classified parameter?
| @@ -265,7 +265,8 @@ def all_downloads(request, platform, channel): | |||
|
|
|||
| context = { | |||
| 'platform': platform, | |||
| 'platforms': product.platforms(channel), | |||
| 'platforms': product.platforms(channel, True), | |||
| 'platform_cls': product.platform_classification, | |||
There was a problem hiding this comment.
While this works for FirefoxAndroid (I believe through the __getattr__ implementation in ProductDetails), I think it would be clearer to explicitly set plaform_classification = None (with a comment) in the FirefoxAndroid class in firefox_details.py.
This will make understanding/reading the code quite a bit simpler for those unfamiliar with ProductDetails.
There was a problem hiding this comment.
Thanks @jpetto! Added comments as well as plaform_classification = None for FirefoxAndroid.
…it version (to limit the number of 32 downloads)
kyoshino
force-pushed
the
demo/firefox-all
branch
from
19c02fb
to
83c5232
Compare
|
Thanks @kyoshino! |
Description
Issue / Bugzilla link
Bug 1430027 - On the download page, for Linux, highlight the 64-bit version (to limit the number of 32 downloads)
Testing