Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove untranslated meta title and description from /campaign page (#6829) #6902

Merged
merged 1 commit into from Mar 12, 2019
Merged

Remove untranslated meta title and description from /campaign page (#6829) #6902

merged 1 commit into from Mar 12, 2019

Conversation

alexgibson
Copy link
Member

Description

  • We didn't translate the existing meta title & description when porting over the /firefox/campaign/ page. This PR removes those custom strings so the page falls back to using the standard page title / description

Issue / Bugzilla link

#6829

Testing

  • Visit /de/firefox/campaign/ and the meta title & description should be in German instead of English.

@alexgibson alexgibson added Bug 🐛 Something's not working the way it should P3 Third level priority - Nice to have Review: XS Code review time: up to 30min labels Mar 12, 2019
@amychurchwell amychurchwell self-assigned this Mar 12, 2019
amychurchwell
amychurchwell approved these changes Mar 12, 2019
View reviewed changes
Copy link
Contributor

@amychurchwell amychurchwell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm! r+

@amychurchwell amychurchwell merged commit 779c000 into mozilla:master Mar 12, 2019
@alexgibson alexgibson deleted the campaign-meta-strings branch November 15, 2019 15:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@amychurchwell amychurchwell amychurchwell approved these changes

Assignees

@amychurchwell amychurchwell

Labels
Bug 🐛 Something's not working the way it should P3 Third level priority - Nice to have Review: XS Code review time: up to 30min
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@alexgibson @amychurchwell