Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Sandstone (Fixes #8384) #8449

Merged
merged 1 commit into from Jan 23, 2020
Merged

Conversation

alexgibson
Copy link
Member

@alexgibson alexgibson commented Jan 16, 2020

Description

  • Removes Sandstone .less files and images.
  • Removes Sandstone base templates.
  • Removes .less processing from gulpfile.js
  • Removes gulp-less npm dependency.

Issue / Bugzilla link

#8384

Testing

Demo: https://www-demo3.allizom.org/en-US/

  • Are any rogue templates still extending base-resp.html?
  • Are there any rogue .less files still knocking around?
  • Did I miss anything in gulpfile.js?
  • Are there any files still using sandstone images?

Successful test run: https://gitlab.com/mozmeao/www-config/pipelines/109859655

@alexgibson alexgibson added P3 Third level priority - Nice to have Needs Review Awaiting code review Review: S Code review time: 30 mins to 1 hour labels Jan 16, 2020
@mozmeao-heroku-bot mozmeao-heroku-bot temporarily deployed to www-demo3 January 16, 2020 10:46 Inactive
@craigcook craigcook self-assigned this Jan 21, 2020
@sgarrity
Copy link
Contributor

"You either die a hero, or live long enough to see your code deprecated and removed." ;-)

Copy link
Member

@craigcook craigcook left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

☠️☠️☠️☠️☠️☠️ FLAWLESS VICTORY ☠️☠️☠️☠️☠️☠️

@craigcook craigcook merged commit 7a2d812 into mozilla:master Jan 23, 2020
@craigcook craigcook removed the Needs Review Awaiting code review label Jan 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
P3 Third level priority - Nice to have Review: S Code review time: 30 mins to 1 hour
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants