Bug 837763 - Add Firefox's Google+ and YouTube links to universal footer #884
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also fixes Bug 638699 - On HTTPS connection, links to Facebook and Twitter should be HTTPS
| <li><a href="https://twitter.com/firefox">{{_('Twitter')}}</a></li> | ||
| <li><a href="https://facebook.com/Firefox">{{_('Facebook')}}</a></li> | ||
| <li><a href="https://plus.google.com/+firefox/posts">{{_('Google+')}}</a></li> | ||
| <li><a href="http://www.youtube.com/firefoxchannel">{{_('YouTube')}}</a></li> |
There was a problem hiding this comment.
Any reason the YouTube link isn't HTTPS too?
There was a problem hiding this comment.
YouTube is using HTTP by default for now, and if HTTPS is used, we'll face a mixed active content issue (Bug 844556).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also fixes Bug 638699 - Links to Facebook and Twitter should be HTTPS