Airflow task SLA and execution_timeout #2134
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
scholtzan
commented
Jun 16, 2021
Comment on lines
+48
to
+50
| sla=datetime.timedelta(minutes=5), | ||
| execution_timeout=datetime.timedelta(minutes=10), | ||
| email_on_retry=False, |
There was a problem hiding this comment.
I'm only changing the bqetl_public_data_json DAG here for testing. If everything works out we can update the remaining DAGs
scholtzan
commented
Jun 16, 2021
Comment on lines
+163
to
+164
| sla: Optional[str] = attr.ib(None) # todo: set to 3h | ||
| execution_timeout: Optional[str] = attr.ib(None) # todo: set to 24h |
There was a problem hiding this comment.
If the testing is successful and we decide to go for setting sla and execution_timeout for the other tasks, then we should set them to the default values in the comments
jklukas
approved these changes
Jun 17, 2021
| @@ -85,6 +91,12 @@ with DAG('{{ name }}', default_args=default_args{%+ if schedule_interval != None | |||
| {%+ if task.email_on_retry != None -%} | |||
| email_on_retry={{ task.email_on_retry }}, | |||
| {%+ endif -%} | |||
| {%+ if task.sla != None -%} | |||
There was a problem hiding this comment.
Suggested change
| {%+ if task.sla != None -%} | |
| {%+ if task.sla is not none -%} |
Jinja has a none test: https://jinja.palletsprojects.com/en/2.11.x/templates/#none
My intuition says we should be using that rather than != None, but I don't fully understand the implications in the Jinja context.
Comment on lines
+48
to
+50
| sla=datetime.timedelta(minutes=5), | ||
| execution_timeout=datetime.timedelta(minutes=10), | ||
| email_on_retry=False, |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on proposal https://docs.google.com/document/d/1V8FwVH_oZonh-SLKRbghkzglofRlec7S51QwIIsLZbQ/edit#
I think it makes sense to set an
slafor tasks but also ensure they time out after a while, otherwise we might end up with a lot of tasks retrying taking up all the slots if not detected during triage.