Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug 1711797 Add access point search probes to search clients daily #2253

Merged
merged 5 commits into from
Aug 18, 2021

Conversation

BenWu
Copy link
Contributor

@BenWu BenWu commented Aug 6, 2021

https://bugzilla.mozilla.org/show_bug.cgi?id=1711797
https://mozilla-hub.atlassian.net/browse/DS-1603

See #2252 for upstream clients daily changes

The query tries to use the access point probe data first and uses the old probes if those are missing.

There are changes to the resulting sources which I'm not sure are acceptable or if they break anything:

  • for tagged sap, the string in the source is now tagged instead of sap, e.g. in-content:tagged... or in-content:tagged-follow-on... instead of in-content:sap... or in-content:sap-follow-on...
  • in-content, with ads, and ad click sources now end with .access_point, e.g. in-content:tagged-follow-on:firefox-b-1-d.searchbar instead of in-content:sap-follow-on:firefox-b-1-d
  • with ads and ad click previously only looked like search-with-ads: or ad-click:, they now have tagged information and access point, e.g. ad-click:organic.reload

@BenWu BenWu force-pushed the benwu/sap-source-clients-daily-part-2-the-SQL-sequel branch from 0db5a72 to 81554c1 Compare August 11, 2021 17:38
@BenWu BenWu marked this pull request as ready for review August 11, 2021 18:19
@BenWu BenWu requested a review from akkomar August 11, 2021 18:19
@akkomar
Copy link
Collaborator

akkomar commented Aug 12, 2021

There are changes to the resulting sources which I'm not sure are acceptable or if they break anything:

* for tagged sap, the string in the source is now `tagged` instead of `sap`, e.g. `in-content:tagged...` or `in-content:tagged-follow-on...` instead of `in-content:sap...` or `in-content:sap-follow-on...`

* in-content, with ads, and ad click sources now end with `.access_point`, e.g. `in-content:tagged-follow-on:firefox-b-1-d.searchbar` instead of `in-content:sap-follow-on:firefox-b-1-d`

* with ads and ad click previously only looked like `search-with-ads:` or `ad-click:`, they now have tagged information and access point, e.g. `ad-click:organic.reload`

@xluo-ds would these break any queries or dashboards?

@BenWu
Copy link
Contributor Author

BenWu commented Aug 12, 2021

We had some discussion here https://mozilla-hub.atlassian.net/browse/DS-1603 and it sounds like it should be fine but I'll wait for confirmation

@BenWu BenWu merged commit d7c904f into main Aug 18, 2021
@BenWu BenWu deleted the benwu/sap-source-clients-daily-part-2-the-SQL-sequel branch August 18, 2021 21:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants