Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Have Glean stable views parse datetime metrics as timestamps (bug 1771733) (#3343)" #3394

Merged
merged 1 commit into from Dec 1, 2022

Conversation

sean-rose
Copy link
Contributor

@sean-rose sean-rose commented Dec 1, 2022

This reverts #3343, which had the unfortunate side effect of causing the search_derived.mobile_search_clients_daily_v1 ETL query to exceed the query complexity limit in the moz-fx-data-shared-prod project (bug 1803534).

We have requested that Google increase the query complexity limit in the moz-fx-data-shared-prod project, but that's not guaranteed to happen in a timely fashion (or at all), so in the meantime reverting #3343 is the easiest way to get the search_derived.mobile_search_clients_daily_v1 ETL (and all its downstream dependencies) working again.


Checklist for reviewer:

  • Commits should reference a bug or github issue, if relevant (if a bug is referenced, the pull request should include the bug number in the title).
  • If the PR comes from a fork, trigger integration CI tests by running the Push to upstream workflow and provide the <username>:<branch> of the fork as parameter. The parameter will also show up
    in the logs of the manual-trigger-required-for-fork CI task together with more detailed instructions.
  • If adding a new field to a query, ensure that the schema and dependent downstream schemas have been updated.
  • When adding a new derived dataset, ensure that data is not available already (fully or partially) and recommend extending an existing dataset in favor of creating new ones. Data can be available in the bigquery-etl repository, looker-hub or in looker-spoke-default.

For modifications to schemas in restricted namespaces (see CODEOWNERS):

Copy link
Collaborator

@fbertsch fbertsch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

r+ assuming this is a straight revert

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants