Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reapply "Have Glean stable views parse datetime metrics as timestamps (bug 1771733) (#3343)" #3453

Merged
merged 2 commits into from Dec 13, 2022

Conversation

sean-rose
Copy link
Contributor

This reapplies #3343, which was temporarily reverted in #3394 because it had the unfortunate side effect of causing the search_derived.mobile_search_clients_daily_v1 ETL query to exceed the query complexity limit in the moz-fx-data-shared-prod project (bug 1803534).

Now the query complexity limit in the moz-fx-data-shared-prod project has been increased, and I've confirmed that the search_derived.mobile_search_clients_daily_v1 ETL won't exceed the query complexity limit with this change applied.


Checklist for reviewer:

  • Commits should reference a bug or github issue, if relevant (if a bug is referenced, the pull request should include the bug number in the title).
  • If the PR comes from a fork, trigger integration CI tests by running the Push to upstream workflow and provide the <username>:<branch> of the fork as parameter. The parameter will also show up
    in the logs of the manual-trigger-required-for-fork CI task together with more detailed instructions.
  • If adding a new field to a query, ensure that the schema and dependent downstream schemas have been updated.
  • When adding a new derived dataset, ensure that data is not available already (fully or partially) and recommend extending an existing dataset in favor of creating new ones. Data can be available in the bigquery-etl repository, looker-hub or in looker-spoke-default.

For modifications to schemas in restricted namespaces (see CODEOWNERS):

@sean-rose sean-rose enabled auto-merge (squash) December 13, 2022 00:48
@sean-rose sean-rose merged commit 756f4ae into main Dec 13, 2022
@sean-rose sean-rose deleted the reapply-pr3343 branch December 13, 2022 00:54
sean-rose added a commit to mozilla/lookml-generator that referenced this pull request Nov 7, 2023
This should have been done when we changed the Glean ping views to convert datetime metrics to timestamps (mozilla/bigquery-etl#3453).
sean-rose added a commit to mozilla/lookml-generator that referenced this pull request Nov 8, 2023
…ws (#806)

* Generate time dimension groups for datetime metrics in Glean ping views.

  This should have been done when we changed the Glean ping views to convert datetime metrics to timestamps (mozilla/bigquery-etl#3453).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants