-
Notifications
You must be signed in to change notification settings - Fork 246
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Test suite fails with Python 3.8.1 #503
Comments
https://github.com/matrix-org/synapse/releases/tag/1.7.2 Building for now with Python 3.7 as Python 3.8.1 changed it's behavior regarding URL parsing[1] which broke one of its dependencies[2]. [1] https://bugs.python.org/issue27657 [2] https://hydra.nixos.org/build/108652790 / mozilla/bleach#503
https://github.com/matrix-org/synapse/releases/tag/1.7.2 Building for now with Python 3.7 as Python 3.8.1 changed it's behavior regarding URL parsing[1] which broke one of its dependencies[2]. [1] https://bugs.python.org/issue27657 [2] https://hydra.nixos.org/build/108652790 / mozilla/bleach#503 (cherry picked from commit 880e098)
@Ma27 Hi, any progress with the patch? Thanks! |
Huh, I thought I provided a status update here as well, sorry! Unfortunately I'm not sure if I actually want to work around this, the code already depends on some heuristics and I'm afraid that patching around in there will cause some mean regressions. I still hope that the change gets reverted again: python/cpython#16839 (comment) |
I don't see much evidence of upstream python3.8 activity to revert. Even if they do, the same problem will occur once 3.9 is out, so it's got to be solved sooner or later. |
Agreed. While taking a look at this a few months ago I realized though that sanitizing has more culprits than I anticipated, so unless the change is reverted, someone else should fix the library accordingly. |
This reverts commit d15fd75.
This happens since
urllib.parse
parses URLs likepath:80
asscheme=path,path=80
(https://bugs.python.org/issue27657).Which causes errors like this:
Currently preparing a patch for this :)
The text was updated successfully, but these errors were encountered: