Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

matrix-synapse: 1.7.1 -> 1.7.2 #76097

Merged
merged 1 commit into from Dec 21, 2019
Merged

matrix-synapse: 1.7.1 -> 1.7.2 #76097

merged 1 commit into from Dec 21, 2019

Conversation

@Ma27
Copy link
Member

@Ma27 Ma27 commented Dec 20, 2019

Motivation for this change

https://github.com/matrix-org/synapse/releases/tag/1.7.2

Building for now with Python 3.7 as Python 3.8.1 changed it's behavior
regarding URL parsing[1] which broke one of its dependencies[2].

[1] https://bugs.python.org/issue27657
[2] https://hydra.nixos.org/build/108652790 / mozilla/bleach#503

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @

@pacien
Copy link
Contributor

@pacien pacien commented Dec 20, 2019

Maybe add a comment referencing #76093 so that we keep track of this.

@ofborg test matrix-synapse

https://github.com/matrix-org/synapse/releases/tag/1.7.2

Building for now with Python 3.7 as Python 3.8.1 changed it's behavior
regarding URL parsing[1] which broke one of its dependencies[2].

[1] https://bugs.python.org/issue27657
[2] https://hydra.nixos.org/build/108652790 / mozilla/bleach#503
@Ma27 Ma27 force-pushed the Ma27:bump-matrix-synapse branch from 2139d17 to 880e098 Dec 20, 2019
@Ma27
Copy link
Member Author

@Ma27 Ma27 commented Dec 20, 2019

Maybe add a comment referencing #76093 so that we keep track of this.

👍 - updated

@pacien
pacien approved these changes Dec 20, 2019
@ofborg ofborg bot requested a review from pacien Dec 20, 2019
@pacien
pacien approved these changes Dec 20, 2019
Copy link
Member

@WilliButz WilliButz left a comment

successfully upgraded 👍

@WilliButz WilliButz merged commit 3f998fa into NixOS:master Dec 21, 2019
16 checks passed
16 checks passed
Evaluation Performance Report Evaluator Performance Report
Details
grahamcofborg-eval ^.^!
Details
grahamcofborg-eval-check-maintainers matching changed paths to changed attrs...
Details
grahamcofborg-eval-check-meta config.nix: checkMeta = true
Details
grahamcofborg-eval-darwin nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A darwin-tested
Details
grahamcofborg-eval-nixos nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release-combined.nix -A tested
Details
grahamcofborg-eval-nixos-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release.nix -A manual
Details
grahamcofborg-eval-nixos-options nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release.nix -A options
Details
grahamcofborg-eval-nixpkgs-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A manual
Details
grahamcofborg-eval-nixpkgs-tarball nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A tarball
Details
grahamcofborg-eval-nixpkgs-unstable-jobset nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A unstable
Details
grahamcofborg-eval-package-list nix-env -qa --json --file .
Details
grahamcofborg-eval-package-list-no-aliases nix-env -qa --json --file . --arg config { allowAliases = false; }
Details
matrix-synapse on aarch64-linux Success
Details
matrix-synapse on x86_64-darwin Success
Details
matrix-synapse on x86_64-linux Success
Details
@WilliButz
Copy link
Member

@WilliButz WilliButz commented Dec 21, 2019

backported in 9683818

@Ma27 Ma27 deleted the Ma27:bump-matrix-synapse branch Dec 21, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.