Use ASCII digits in port number parsing #207
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, bleach accepts (linkyfies) the following “URLs”:
http://foo.com:𝟠𝟘𝟠𝟘/
http://foo.com:٣٩٩٩/
That is because the
\d
modifier of Python unicode regular expressions matches all digits in the Nd block (search forcategory [Nd]
here), and there are many things in there.This PR replaces
\d
with[0-9]+
and two test URLs to assert these links are not recognized.Note: an alternative would be to use the
re.ASCII
flag but:Note: funnily enough, GitHub-flavored markdown also linkyfies them! http://foo.com:𝟠𝟘𝟠𝟘/