Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use correct Privacy Policy link in welcome dialog #4157

Merged
merged 2 commits into from
Feb 6, 2024

Conversation

Vinnl
Copy link
Collaborator

@Vinnl Vinnl commented Feb 6, 2024

References:

Jira: MNTOR-2903
Figma: N/A

Description

When entering your info in the onboarding flow, the dialog should link to https://www.mozilla.org/privacy/subscription-services/ for the privacy policy. (The current link does redirect there, but still.)

Screenshot (if applicable)

Not applicable.

How to test

Open the EnterInfo screen, open the dialog, follow the link.

Checklist (Definition of Done)

  • Localization strings (if needed) have been added.
  • Commits in this PR are minimal and have descriptive commit messages.
  • I've added or updated the relevant sections in readme and/or code comments
  • I've added a unit test to test for potential regressions of this bug. - N/A, I'd just copy-paste the same link to the test
  • Product Owner accepted the User Story (demo of functionality completed) or waived the privilege.
  • All acceptance criteria are met.
  • Jira ticket has been updated (if needed) to match changes made during the development process.
  • Jira ticket has been updated (if needed) with suggestions for QA when this PR is deployed to stage.

@Vinnl Vinnl added the Review: µ Code review time: 5 minutes or less label Feb 6, 2024
@Vinnl Vinnl requested review from codemist and flozia February 6, 2024 12:19
@Vinnl Vinnl self-assigned this Feb 6, 2024
@@ -26,6 +26,7 @@ import {
import { meetsAgeRequirement } from "../../../../../functions/universal/user";
import { getLocale } from "../../../../../functions/universal/getLocale";
import { useTelemetry } from "../../../../../hooks/useTelemetry";
import { CONST_URL_PRIVACY_POLICY } from "../../../../../../constants";
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh, we're not settings the links in the env anymore?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nope! See #4005 for the reasoning.

@rhelmer rhelmer merged commit f9b0817 into main Feb 6, 2024
12 checks passed
@rhelmer rhelmer deleted the MNTOR-2903-privacy-policy-link branch February 6, 2024 18:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Review: µ Code review time: 5 minutes or less
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants