Add last scan date below upsell button #4407
Conversation
|
Putting back in draft mode - it needs to be put behind a feature flag. |
| } | ||
|
|
||
| const scan = await knex("onerep_scans") | ||
| .first() | ||
| .where("onerep_profile_id", onerepProfileId) | ||
| .orderBy("created_at", "desc"); | ||
|
|
||
| return scan ?? null; |
There was a problem hiding this comment.
Interesting! What does this do?
I thought the nullish coalescing would only return the right-hand side if the left-hand side was already null.
There was a problem hiding this comment.
Nullish coalescing returns the right-hand side if the left-hand side is null or undefined. So this ensures we return null if there was no result.
|
Flag added in dd3d4d8. |
After all, it's part of the toolbar.
(Only shown if the user has performed a scan.)
Supposedly that's a prerequisite for making it part of an experiment.
Vinnl
force-pushed
the
MNTOR-2701-last-scan
branch
from
9fa38fb
to
b13ca39
Compare
I'm not actually sure if we made a decision on that, but we're going to run an experiment for it, so we'll first have to set that up anyway. Possibly we'll move it over a bit after that. (Which isn't a major redesign anyway, just putting it to the left of the badge.) |
References:
Jira: MNTOR-2701
Figma: https://www.figma.com/file/DTbmXzCQCw2PxXpHQW8yfW/Monitor-MVP-Enhancements?type=design&node-id=24-538&mode=design
Description
Lets a user know when their last scan took place.
Note that I also moved
UpsellBadge.tsxinto thetoolbarfolder, since it's shown in the toolbar.Screenshot (if applicable)
How to test
Open the dashboard with a user who has performed a scan.
Checklist (Definition of Done)