This repository has been archived by the owner on Feb 8, 2019. It is now read-only.
[bug 1061561] Solve a question #67
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Feature related: - Display the buttons and solution text appropriately - Marks as helpful and solves the question - Close the question when solved Also fixed while there: - Change the app base font size to fix the button sizes (funny looking UI but that will be fixed when we focus on implementing the visual design) - Overrides a building block for the new dialog - Moved some content from unspecific buddyup.css to specific comment.css - Store the answer_id on the comment rather than each button - Used 'js-' prefixed classes for DOM selection to separate from CSS style - Closing dialogs is now factored in one event handler - Fixed the dialog for first time question
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Feature related:
Also fixed while there: