Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Port to Python Requests #4

Closed
ghost opened this issue Dec 16, 2014 · 5 comments
Closed

Port to Python Requests #4

ghost opened this issue Dec 16, 2014 · 5 comments

Comments

@ghost
Copy link

ghost commented Dec 16, 2014

We should consider porting the urllib and urllib2 code to python requests perhaps this could be a contribution opportunity or good first bug.
@anoopvalluthadam
Copy link
Contributor

@bkerensa @sylvestre I am working on it.

@sylvestre
Copy link
Contributor

Ok, great, please write unit tests if you can :)
(noise is fine)

Le 22 août 2015 14:49:40 GMT+02:00, Anoop Valluthadam notifications@github.com a écrit :

@bkerensa @sylvestre I am working on it.

Reply to this email directly or view it on GitHub:
#4 (comment)

Envoyé de mon téléphone Android avec K-9 Mail. Excusez la brièveté.

@anoopvalluthadam
Copy link
Contributor

@sylvestre Cool, I will write unit test as well.

Hope you mentioned nose - https://nose.readthedocs.org/en/latest/

@sylvestre
Copy link
Contributor

Yep, my bad, sorry :)

@anoopvalluthadam anoopvalluthadam mentioned this issue Oct 19, 2015
Merged
@sylvestre
Copy link
Contributor

Implemented in the PR #29

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@anoopvalluthadam @sylvestre