Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Bump pandas from 2.1.0 to 2.1.1" #3753

Merged
merged 1 commit into from
Oct 24, 2023

Conversation

suhaibmujahid
Copy link
Member

This reverts commit 31b45c9. Regressed by #3672.

When depending on pandas v2.1.1, it requires a newer version of numpy on Python 11+1, which causes a dependency conflict2.

Footnotes

  1. https://github.com/pandas-dev/pandas/blob/v2.1.1/pyproject.toml#L32-L34

  2. https://github.com/mozilla/bugbug/pull/3752#issuecomment-1776315221

@suhaibmujahid
Copy link
Member Author

suhaibmujahid commented Oct 24, 2023

Updating numpy to the latest version is another way to solve the dependency conflict mentioned in #3752 (comment), but that requires fixing some breakages. I filed #3754 to follow up on that.

@marco-c
Copy link
Collaborator

marco-c commented Oct 24, 2023

I wonder why the error isn't seen on CI or on my machine :S

@marco-c marco-c merged commit e6aa3f8 into mozilla:master Oct 24, 2023
6 checks passed
@suhaibmujahid
Copy link
Member Author

I wonder why the error isn't seen on CI or on my machine :S

The CI uses Python 10 and I guess you use the same version locally as well. The error happens when using Python 11+.

@suhaibmujahid suhaibmujahid deleted the pandas-2.1.0 branch October 25, 2023 13:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants