Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/add-CI-tests #3763

Draft
wants to merge 7 commits into
base: master
Choose a base branch
from
Draft

Conversation

unna97
Copy link

@unna97 unna97 commented Oct 27, 2023

No description provided.

Copy link
Member

@suhaibmujahid suhaibmujahid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @unna97 for the PR. In general, it would be better to start by opening an issue to discuss the idea. I will discuss with the team whether we want to use Github Actions in this context.

Please edit the PR title and description to be more descriptive.

.github/workflows/test.yaml Outdated Show resolved Hide resolved
.github/workflows/test.yaml Outdated Show resolved Hide resolved
.github/workflows/test.yaml Outdated Show resolved Hide resolved
.gitignore Outdated Show resolved Hide resolved
@unna97
Copy link
Author

unna97 commented Oct 27, 2023

Thank you @suhaibmujahid . In all honesty, the tests were failing in my local setup. (I am currently on windows, python 3.10). So I was wondering if it was an os specific issue or a python issue. So I created the above matrix. The above pull request failed for 3.11 on all the different os. I added the workflow_dispatch to run the tests. I was unable it to test it because I believe it requires your approval.

unna97 and others added 2 commits October 27, 2023 22:54
Co-authored-by: Suhaib Mujahid <suhaibmujahid@gmail.com>
Co-authored-by: Suhaib Mujahid <suhaibmujahid@gmail.com>
@suhaibmujahid
Copy link
Member

In all honesty, the tests were failing in my local setup. (I am currently on windows, python 3.10).

You could try WSL if you have problems on Windows.

The above pull request failed for 3.11 on all the different os.

The dependency conflict on Python 3.11 was fixed in #3753. If you pull the latest upstream changes, you should have that problem fixed.

@unna97
Copy link
Author

unna97 commented Oct 27, 2023

@suhaibmujahid The installation is failing on 3.11 on ubuntu due to numpy. Please see here: https://github.com/unna97/bugbug/actions/runs/6677816934?pr=1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants