This repository has been archived by the owner on Jan 20, 2022. It is now read-only.
All clobbers endpoints #32
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This will aid in batching clobbers.
| return session.query(ClobberTime).order_by(ClobberTime.lastclobber) | ||
|
|
||
|
|
||
| @bp.route('/lastclobber/greater-than/<int:mintime>', methods=['GET']) |
There was a problem hiding this comment.
This might be better as /lastclobber/since/<int:mintime> or even /lastclobber/all?since=<int:mintime>.
There was a problem hiding this comment.
@djmitche oooh, yes, I like that idea. Thanks!
This discussions with developers revealed that this information was un-necesarry.
The complex query turns out to be necessary, because we still support clobbering individual slaves. i.e. we can have the same builddir with multiple clobbertimes, so the "max n per group" must be calculated.
|
👍 |
|
/me makes it so |
ghost
merged commit
This pull request was closed.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Two new endpoints, which allow one to get an overall view of what has been recently clobbered. Using these endpoints in tandem, you could build a manifest (with all) then update it periodically (using greater-than) to achieve branch agnostic bulk clobbers.
/clobberer/lastclobber/all
/clobberer/lastclobber/greater-than/