This repository has been archived by the owner on Jan 20, 2022. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 6
All clobbers endpoints #32
Merged
Merged
Changes from 3 commits
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -136,11 +136,31 @@ def branches(): | |
return [branch[0] for branch in branches] | ||
|
||
|
||
@bp.route('/lastclobber/all', methods=['GET']) | ||
@apimethod([rest.ClobberTime]) | ||
def lastclobber_all(): | ||
"Return a sorted list of all clobbers" | ||
session = g.db.session(DB_DECLARATIVE_BASE) | ||
return session.query(ClobberTime).order_by(ClobberTime.lastclobber) | ||
|
||
|
||
@bp.route('/lastclobber/greater-than/<int:mintime>', methods=['GET']) | ||
@apimethod([rest.ClobberTime], int) | ||
def lastclobber_greater_than(mintime): | ||
"Return a sorted list of all clobbers greater than the time passed in" | ||
session = g.db.session(DB_DECLARATIVE_BASE) | ||
return session.query(ClobberTime).filter( | ||
ClobberTime.lastclobber > mintime | ||
).order_by(ClobberTime.lastclobber) | ||
|
||
|
||
@bp.route('/lastclobber/branch/by-builder/<string:branch>', methods=['GET']) | ||
@apimethod({unicode: [rest.ClobberTime]}, unicode) | ||
def lastclobber_by_builder(branch): | ||
"Return a dictionary of most recent ClobberTimes grouped by buildername." | ||
|
||
# TODO: simplify this query, new clobberer _only_ tracks max clobber times | ||
# - old clobberer did not - so this query may be simplified under that | ||
# assuption | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Let's get a bug or issue on file and point to it in this comment -- sounds like a good fix for a first-time contributor or a sprint. |
||
session = g.db.session(DB_DECLARATIVE_BASE) | ||
|
||
# Isolates the maximum lastclobber for each builddir on a branch | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This might be better as
/lastclobber/since/<int:mintime>
or even/lastclobber/all?since=<int:mintime>
.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@djmitche oooh, yes, I like that idea. Thanks!