-
Notifications
You must be signed in to change notification settings - Fork 43
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Additional tracing messages to diagnose missing audit criteria. #592
Conversation
This PR helped me diagnose problems I've encountered when trying to import https://raw.githubusercontent.com/google/rust-crate-audits/main/manual-sources/google3-audits.toml into Chromium (see Chromium's config.toml here). PTAL? |
/cc @danakj |
Thanks for reviewing @mystor. Can you PTAL again? |
src/storage.rs
Outdated
return None; | ||
retain_only_known_criteria(&mut wildcard_entry.criteria, valid_criteria); | ||
if wildcard_entry.criteria.is_empty() { | ||
None |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
None | |
info!("imported wildcard audit parsing failed due to no known criteria"); | |
None |
Thanks for the review @mystor! Two quick notes:
|
This is actually #602 as far as I can tell, and those failures should be fixed now since #603. |
Thanks for the other upstream fixes. FWIW |
5ab1de7
to
c241882
Compare
Thanks! |
No description provided.