Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hide social links that are empty #70

Merged
merged 2 commits into from
Nov 21, 2019

Conversation

dnaluz
Copy link
Collaborator

@dnaluz dnaluz commented Nov 20, 2019

Hide social links / section if none are set for a group

@kycapstick
Copy link
Collaborator

This looks great!

One quick thing I noticed it isn't showing the proper identicon for group admins. I believe the issue is that at the end of line 576 of group.php it reads data-username="<?php print $member->data->user_nicename; ?> but should read data-username="<?php print $u->user_nicename; ?>

@dnaluz
Copy link
Collaborator Author

dnaluz commented Nov 20, 2019

@kycapstick the identicon bug should be fixed now.

@dnaluz dnaluz merged commit 5d2015a into develop Nov 21, 2019
@Mte90 Mte90 deleted the fix/moz-259-hide-social-links-empty branch September 29, 2021 17:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants