Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

twitter.com rule is clicking other popups than cookie banners in Firefox for Android #68

Closed
Amejia481 opened this issue Nov 29, 2022 · 0 comments · Fixed by #107
Closed

twitter.com rule is clicking other popups than cookie banners in Firefox for Android #68

Amejia481 opened this issue Nov 29, 2022 · 0 comments · Fixed by #107
Labels
rule-site-breakage Sites that break from acting on a rule.

Comments

@Amejia481
Copy link

For more details see:
mozilla-mobile/fenix#27719 (comment)
https://bugzilla.mozilla.org/show_bug.cgi?id=1803117#c2
@Trikolon Trikolon added the rule-site-breakage Sites that break from acting on a rule. label Nov 29, 2022
Trikolon added a commit that referenced this issue Dec 1, 2022
@Trikolon
Fix the rule for twitter.com
afb0aea 
The click rule was too generic causing false-positives.
The updated rule relies on cookie injection rather than clicking. It sets the d_prefs cookie which is a base64 encoded version of the cookie banner preferences.
Fixes #68
@Trikolon Trikolon mentioned this issue Dec 1, 2022
Merged
Trikolon added a commit that referenced this issue Dec 1, 2022
@Trikolon
Fix the rule for twitter.com (#107)
e8678fd 
The click rule was too generic causing false-positives.
The updated rule relies on cookie injection rather than clicking. It sets the d_prefs cookie which is a base64 encoded version of the cookie banner preferences.
Fixes #68
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
rule-site-breakage Sites that break from acting on a rule.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix the rule for twitter.com mozilla/cookie-banner-rules-list
2 participants
@Amejia481 @Trikolon