Skip to content
This repository has been archived by the owner on Feb 20, 2023. It is now read-only.

[Bug]: Unable to load Twitter in Fenix Nightly only in Private Browsing mode #27719

Closed
Fanolian opened this issue Nov 5, 2022 · 20 comments
Closed
Assignees
Labels
🐞 bug Crashes, Something isn't working, .. eng:qa:verified QA Verified needs:triage Issue needs triage qa-triaged Issues triaged by qa S3 Blocks non-critical functionality and a work around exists

Comments

@Fanolian
Copy link

Fanolian commented Nov 5, 2022

Steps to reproduce

  1. Open Private Browsing mode in Fenix.
  2. Go to any Twitter page, e.g. https://www.twitter.com/firefox/.
  3. Click cancel when the prompt of opening link in app appears.

Expected behaviour

The page should be loaded in Fenix successfully.

Actual behaviour

A prompt about opening the link in app appears. Clicking cancel does not load the link in Fenix. It shows a blank page instead.
In non-PB mode, I can load the link properly.

Video of the issue:

Fenix.PB.mode.Twitter.compressed.mp4

(Or original quality 66MB: https://giant.gfycat.com/GargantuanPossibleAsiandamselfly.mp4)

Device name

Google Pixel 4a

Android version

Android 13 October 2022 update

Firefox release type

Firefox Nightly

Firefox version

108.0a1 (Build #2015913675), 408d15a+ AC: 108.0.20221103143443, 5cc49c0 GV: 108.0a1-20221103095349 AS: 94.3.2 2022-11-03T17:07:17.965436

Device logs

No response

Additional information

I cannot reproduce the issue in non-PB mode. (Shown in the last part of the attached video)
I cannot reproduce it in PB mode of Fenix Release 106.1.0 (Build #2015909131), 71ca6c1+ AC: 106.0.5, 5f06485fc3 GV: 106.0-20221010181815 AS: 94.2.1 2022-10-11T01:08:43.974343

It is reproducible either Open links in apps in Settings is enabled or not.
It is reproducible with all addons disabled.
I have tried turning Enhanced Tracking Protection off and deleting browsing data, except history and site data.

I do not have Twitter app installed. I tried installing it (But without logging on) but the issue persists.

┆Issue is synchronized with this Jira Task
┆Link To Issue: https://mozilla-hub.atlassian.net/browse/FNXV2-21934

@Fanolian Fanolian added needs:triage Issue needs triage 🐞 bug Crashes, Something isn't working, .. labels Nov 5, 2022
@kbrosnan

This comment was marked as outdated.

@kbrosnan kbrosnan closed this as completed Nov 6, 2022
@kbrosnan kbrosnan closed this as not planned Won't fix, can't repro, duplicate, stale Nov 6, 2022
@kbrosnan kbrosnan reopened this Nov 6, 2022
@AdinaPetridean
Copy link

@Fanolian thank you for your report! I was able to reproduce this issue on Firefox Nightly 108.0a1- 7/11 with One plus 9 Pro (Android 12). However I only reproduced it after reloading the twitter page (not on the first try).

@AdinaPetridean AdinaPetridean added qa-triaged Issues triaged by qa S3 Blocks non-critical functionality and a work around exists labels Nov 7, 2022
@Fanolian
Copy link
Author

Fanolian commented Nov 7, 2022

I tried Wikipedia which triggers open-in-app prompts. It works but the address given in the prompt is https://, not intent:// like Twitter. I don't know any other sites that also open an intent:// address.

@shtstorm
Copy link

shtstorm commented Nov 8, 2022

The problem is with any Twitter link and any embedded Twitter post on any page. If you start with a page in Private Browsing mode and click on a Twitter link, there will be one or more "intent" pop ups and the page would fail to load.

For instance, open this page in PB mode and click on this link: Firefox 🔥 (@firefox) / Twitter

This is probably a higher priority issue because Twitter is broken as of now in permanent PB mode.

@yoasif
Copy link
Contributor

yoasif commented Nov 21, 2022

This issue is now present in beta - we are seeing reports elsewhere.

It is also happening in non-private browsing mode in Nightly, so I think this is a pretty serious issue.

@rocketsroger
Copy link
Contributor

rocketsroger commented Nov 21, 2022

More investigation is needed, but this could be related. Tested, unrelated.

@rocketsroger rocketsroger self-assigned this Nov 21, 2022
@plwt
Copy link

plwt commented Nov 22, 2022

@plwt
Copy link

plwt commented Nov 22, 2022

@Fanolian
Copy link
Author

It doesn't work in non-PB mode now. Loading a twitter page will open Google Play Store.

@t-p-white
Copy link
Contributor

t-p-white commented Nov 23, 2022

@Fanolian thank you for your report! I was able to reproduce this issue on Firefox Nightly 108.0a1- 7/11 with One plus 9 Pro (Android 12). However I only reproduced it after reloading the twitter page (not on the first try).

Confirm this is also the case while testing on Pixel 7 (Android 13)

It doesn't work in non-PB mode now. Loading a twitter page will open Google Play Store.

Thanks @Fanolian, also confirmed on Pixel 7 (Android 13)

@boek
Copy link
Contributor

boek commented Nov 25, 2022

@rocketsroger @t-p-white - @zmckenney and I fell into investigating this on Friday (The last work day before Thanksgiving break) and we found out that this may be caused by cookie banner handling set to Enabled (Accept or accept all). It appears that whatever heuristics we use to detect cookie banners thinks that the Open in App banner is one. Accepting it redirects to https://twitter.app.link which then takes you to the play store.

@rocketsroger
Copy link
Contributor

@rocketsroger @t-p-white - @zmckenney and I fell into investigating this on Friday and we found out that this may be caused by cookie banner handling set to Enabled (Accept or accept all). It appears that whatever heuristics we use to detect cookie banners thinks that the Open in App banner is one. Accepting it redirects to https://twitter.app.link which then takes you to the play store.

Thanks Jeff, this is a good observation.

@rocketsroger
Copy link
Contributor

rocketsroger commented Nov 28, 2022

I can confirm that I can reproduce with an older Nightly and latest Beta but not with latest Nightly build. @Fanolian, @yoasif and @shtstorm, can you please help me confirm this finding? Thanks

@rocketsroger rocketsroger added the eng:qa:needed QA Needed label Nov 28, 2022
@rocketsroger
Copy link
Contributor

Adding QA to confirm that with latest Nightly this is not reproducible. Thanks

@rocketsroger
Copy link
Contributor

This said, I'm still trying to figure out what's causing the problem in Beta.

@rocketsroger
Copy link
Contributor

Confirmed @boek's and @zmckenney's investigation. This issue is related to Cookie Banner Protection. Thanks

@Fanolian
Copy link
Author

Confirm that this can't be reproduced in latest Nightly, PB or non-PB mode.

@rocketsroger
Copy link
Contributor

Bugzilla issue created.

@AdinaPetridean
Copy link

Verified as fixed on the latest Nightly 109.0a1 from 29/11 with Motorola Moto G9 plus (Android 11). This issue is no longer reproducible in normal or private browsing.

twitter.mp4

@kbrosnan
Copy link
Contributor

This is being tracked in the upstream bug.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
🐞 bug Crashes, Something isn't working, .. eng:qa:verified QA Verified needs:triage Issue needs triage qa-triaged Issues triaged by qa S3 Blocks non-critical functionality and a work around exists
Projects
None yet
Development

No branches or pull requests

9 participants