OpenSL ES full duplex restored #196
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kinetiknz
approved these changes
Nov 18, 2016
| @@ -1360,6 +1361,9 @@ opensl_stream_init(cubeb * ctx, cubeb_stream ** stream, char const * stream_name | |||
| assert(r == 0); | |||
|
|
|||
| if (output_stream_params) { | |||
| LOG("Playback params: Rate %d, channels %d, format %d, latency in frames %d.", | |||
There was a problem hiding this comment.
rate, channels, and latency_frames are unsigned so should be %u. LOG() should be producing -Wformat warnings for these now (on GCC and Clang), please let me know if you're not seeing them.
| @@ -1368,6 +1372,9 @@ opensl_stream_init(cubeb * ctx, cubeb_stream ** stream, char const * stream_name | |||
| } | |||
|
|
|||
| if (input_stream_params) { | |||
| LOG("Capture params: Rate %d, channels %d, format %d, latency in frames %d.", | |||
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Full duplex functionality for OpenSL ES. The patch in the bottom is the same patch which backout in 99d6ae1 rebased to current version. The rest of the patches are all problems found during build, manual testing and try run. Latest try:
https://treeherder.mozilla.org/#/jobs?repo=try&revision=cab4bbde79b65b872f0181b2076d49b3b8df231d
Latest autophone try:
https://treeherder.mozilla.org/#/jobs?repo=try&revision=ae10057481627d78a7b47483adfc27768c985d79
Review @kinetiknz and/or @padenot ?