Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

undo click pinning #91

Closed
willkg opened this issue Oct 22, 2016 · 4 comments
Closed

undo click pinning #91

willkg opened this issue Oct 22, 2016 · 4 comments
Milestone
v1.0.0 clean up p...

Comments

@willkg
Copy link
Member

willkg commented Oct 22, 2016

Currently, we have click pinned to a specific version. We probably shouldn't. Probably good enough to do click>=6.

This needs some research, though. Click history is here:

http://click.pocoo.org/6/changelog/
@willkg
Copy link
Member Author

willkg commented Jan 4, 2017

Pretty sure this is fine. I'll do it in the next release.

@willkg willkg modified the milestone: v0.9 fix the parsing pipeline Jan 4, 2017
@sils
Copy link

sils commented Jan 10, 2017

🎉 and our master builds are broken because of this, we can implement a workaround but would like to see this fixed soon or we probably can't afford supporting dennis in coala :/

@sils
Copy link

sils commented Jan 10, 2017

though tbh pip could have been a little smarter and resolved the dependencies correctly...

sils added a commit to coala/coala-bears that referenced this issue Jan 10, 2017
@sils
requirements.txt: Add click 6.6
291871b 
coala builds are currently failing. This is a hotfix. We should revert
this when mozilla/dennis#91 gets resolved or
alternatively remove DennisBear.
@sils sils mentioned this issue Jan 10, 2017
Merged
sils added a commit to coala/coala-bears that referenced this issue Jan 10, 2017
@sils
requirements.txt: Add click 6.6
0eb2ba1 
coala builds are currently failing. This is a hotfix. We should revert
this when mozilla/dennis#91 gets resolved or
alternatively remove DennisBear.

The dennis requirement is indirect while pip picks up this one:

    Collecting Click>=6.0 (from safety~=0.5.1->coala-bears[alldeps])

This fixes it to 6.6 so everything works temporarily.
sils added a commit to coala/coala-bears that referenced this issue Jan 10, 2017
@sils
requirements.txt: Add click 6.6
f0e8955 
coala builds are currently failing. This is a hotfix. We should revert
this when mozilla/dennis#91 gets resolved or
alternatively remove DennisBear.

The dennis requirement is indirect while pip picks up this one:

    Collecting Click>=6.0 (from safety~=0.5.1->coala-bears[alldeps])

This fixes it to 6.6 so everything works temporarily.
@jayvdb jayvdb mentioned this issue Jan 13, 2017
Closed
@willkg
Copy link
Member Author

willkg commented Feb 14, 2017

Fixed in 033d88d.

@willkg willkg closed this as completed Feb 14, 2017
gosom pushed a commit to gosom/coala-bears that referenced this issue Jul 15, 2017
@sils
requirements.txt: Add click 6.6
ad7e53c 
coala builds are currently failing. This is a hotfix. We should revert
this when mozilla/dennis#91 gets resolved or
alternatively remove DennisBear.

The dennis requirement is indirect while pip picks up this one:

    Collecting Click>=6.0 (from safety~=0.5.1->coala-bears[alldeps])

This fixes it to 6.6 so everything works temporarily.
@Trojan295 Trojan295 mentioned this issue Oct 21, 2017
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v1.0.0 clean up project
Development

No branches or pull requests
2 participants
@willkg @sils