Update dennis to 0.9 #2077

Trojan295 · 2017-10-21T20:05:51Z

Dennis library was updated to 0.9 and it contains the fix for mozilla/dennis#91.

This PR reverts #1282 and updates dennis to 0.9 to solve #1284

nvzard

Please read the commit guidelines and modify your commit according to that.

https://api.coala.io/en/latest/Developers/Writing_Good_Commits.html

RaiVaibhav · 2017-11-11T17:05:38Z

bear-requirements.txt

 cmakelint~=1.3
 cppclean~=0.12.0
 cpplint~=1.3
-dennis~=0.8
+dennis~=0.9


As per the issue you have to update only to version= 0.9. I think have to make it to dennis==0.9 instead dennis~=0.9

unack 996b0b2

No, we avoid == if possible.

ack 996b0b2

jayvdb · 2017-11-16T10:58:31Z

ack 996b0b2

RaiVaibhav · 2017-11-16T11:10:37Z

Problem in coverage on appveyor it's not 100% 😕

jayvdb · 2017-11-16T11:19:53Z

@gitmate-bot rebase

gitmate-bot · 2017-11-16T11:19:55Z

Hey! This pull request is being rebased automatically. Please DO NOT push while rebase is in progress or your changes would be lost!

gitmate-bot · 2017-11-16T11:20:10Z

Automated rebase was successful!

jayvdb · 2017-11-16T11:25:26Z

Problem in coverage on appveyor it's not 100% 😕

ftr, there was no problem here.

jayvdb · 2017-11-16T11:47:51Z

@rultor merge

rultor · 2017-11-16T11:48:42Z

@rultor merge

@jayvdb OK, I'll try to merge now. You can check the progress of the merge here

rultor · 2017-11-16T11:49:10Z

@rultor merge

@Trojan295 @jayvdb Oops, I failed. You can see the full log here (spent 20s)

+ ff=only
+ rebase=false
+ container=coala_coala-bears_2077
+ as_root=true
+ mkdir -p /home/rultor/.ssh
+ echo -e 'Host github.com\n\tStrictHostKeyChecking no\n'
+ chmod 600 /home/rultor/.ssh/config
+ git clone git@github.com:coala/coala-bears.git repo
Cloning into 'repo'...
+ cd repo
+ git config user.email me@rultor.com
+ git config user.name rultor
+ '[' -z 'export '\''fork=git@github.com:Trojan295/coala-bears.git'\''' ']'
+ cd ..
+ cat
+ '[' true = true ']'
+ cat
+ chmod a+x entry.sh
+ cat
+ echo 'export '\''fork=git@github.com:Trojan295/coala-bears.git'\''' ';' 'export '\''fork_branch=issue-1284'\''' ';' 'export '\''head=git@github.com:coala/coala-bears.git'\''' ';' 'export '\''head_branch=master'\''' ';' 'export '\''pull_id=2077'\''' ';' 'export '\''pull_title=Update dennis to 0.9'\''' ';' 'export '\''author=jayvdb'\''' ';' 'DATE=`date --utc +%Y%m%d%H%M%S`' ';' 'python3 .ci/adjust_version_number.py bears/VERSION -b "$DATE"' ';' 'bash .ci/check_maintainership.sh' ';' 'bash .ci/deploy.pypi.sh' ';'
+ gpgconf --reload gpg-agent
+ gpg --keyserver hkp://pool.sks-keyservers.net --verbose --recv-keys 9AF0FA4C
gpg: requesting key 9AF0FA4C from hkp server pool.sks-keyservers.net
gpg: armor header: Version: SKS 1.1.6
gpg: armor header: Comment: Hostname: keys.klaus-uwe.me
gpg: pub  2048R/9AF0FA4C 2014-08-17  Rultor.com <gpg@rultor.com>
gpg: key 9AF0FA4C: "Rultor.com <gpg@rultor.com>" not changed
gpg: Total number processed: 1
gpg:              unchanged: 1
+ gpg --version
gpg (GnuPG) 1.4.20
Copyright (C) 2015 Free Software Foundation, Inc.
License GPLv3+: GNU GPL version 3 or later <http://gnu.org/licenses/gpl.html>
This is free software: you are free to change and redistribute it.
There is NO WARRANTY, to the extent permitted by law.

Home: ~/.gnupg
Supported algorithms:
Pubkey: RSA, RSA-E, RSA-S, ELG-E, DSA
Cipher: IDEA, 3DES, CAST5, BLOWFISH, AES, AES192, AES256, TWOFISH,
        CAMELLIA128, CAMELLIA192, CAMELLIA256
Hash: MD5, SHA1, RIPEMD160, SHA256, SHA384, SHA512, SHA224
Compression: Uncompressed, ZIP, ZLIB, BZIP2
++ pwd
++ pwd
+ gpg --verbose --keyring=/tmp/rultor-mTMF/.gpg/pubring.gpg --secret-keyring=/tmp/rultor-mTMF/.gpg/secring.gpg --decrypt repo/.ci/rultor_secrets.sh.asc
gpg: public key is 9A839C3A
gpg: using subkey 9A839C3A instead of primary key 9AF0FA4C
gpg: using subkey 9A839C3A instead of primary key 9AF0FA4C
gpg: encrypted with 2048-bit RSA key, ID 9A839C3A, created 2014-08-17
      "Rultor.com <gpg@rultor.com>"
gpg: AES256 encrypted data
gpg: original file name='rultor-OCHk'
+ gpg --no-tty --batch --verbose --decrypt --passphrase rultor-key:coala/coala-bears rultor_secrets.sh.enc
gpg: AES encrypted data
gpg: gpg-agent is not available in this session
gpg: encrypted with 1 passphrase
gpg: decryption failed: bad key
'cid' file is absent, container wasn't started correctly

rultor · 2017-11-17T15:25:23Z

@rultor merge

@Makman2 @Trojan295 Oops, I failed. You can see the full log here (spent 22s)

+ ff=only
+ rebase=false
+ container=coala_coala-bears_2077
+ as_root=true
+ mkdir -p /home/rultor/.ssh
+ echo -e 'Host github.com\n\tStrictHostKeyChecking no\n'
+ chmod 600 /home/rultor/.ssh/config
+ git clone git@github.com:coala/coala-bears.git repo
Cloning into 'repo'...
+ cd repo
+ git config user.email me@rultor.com
+ git config user.name rultor
+ '[' -z 'export '\''fork=git@github.com:Trojan295/coala-bears.git'\''' ']'
+ cd ..
+ cat
+ '[' true = true ']'
+ cat
+ chmod a+x entry.sh
+ cat
+ echo 'export '\''fork=git@github.com:Trojan295/coala-bears.git'\''' ';' 'export '\''fork_branch=issue-1284'\''' ';' 'export '\''head=git@github.com:coala/coala-bears.git'\''' ';' 'export '\''head_branch=master'\''' ';' 'export '\''pull_id=2077'\''' ';' 'export '\''pull_title=Update dennis to 0.9'\''' ';' 'export '\''author=makman2'\''' ';' 'DATE=`date --utc +%Y%m%d%H%M%S`' ';' 'python3 .ci/adjust_version_number.py bears/VERSION -b "$DATE"' ';' 'bash .ci/check_maintainership.sh' ';' 'bash .ci/deploy.pypi.sh' ';'
+ gpgconf --reload gpg-agent
+ gpg --keyserver hkp://pool.sks-keyservers.net --verbose --recv-keys 9AF0FA4C
gpg: requesting key 9AF0FA4C from hkp server pool.sks-keyservers.net
gpg: armor header: Version: SKS 1.1.6
gpg: armor header: Comment: Hostname: keys2.flanga.io
gpg: pub  2048R/9AF0FA4C 2014-08-17  Rultor.com <gpg@rultor.com>
gpg: key 9AF0FA4C: "Rultor.com <gpg@rultor.com>" not changed
gpg: Total number processed: 1
gpg:              unchanged: 1
+ gpg --version
gpg (GnuPG) 1.4.20
Copyright (C) 2015 Free Software Foundation, Inc.
License GPLv3+: GNU GPL version 3 or later <http://gnu.org/licenses/gpl.html>
This is free software: you are free to change and redistribute it.
There is NO WARRANTY, to the extent permitted by law.

Home: ~/.gnupg
Supported algorithms:
Pubkey: RSA, RSA-E, RSA-S, ELG-E, DSA
Cipher: IDEA, 3DES, CAST5, BLOWFISH, AES, AES192, AES256, TWOFISH,
        CAMELLIA128, CAMELLIA192, CAMELLIA256
Hash: MD5, SHA1, RIPEMD160, SHA256, SHA384, SHA512, SHA224
Compression: Uncompressed, ZIP, ZLIB, BZIP2
++ pwd
++ pwd
+ gpg --verbose --keyring=/tmp/rultor-Ns7X/.gpg/pubring.gpg --secret-keyring=/tmp/rultor-Ns7X/.gpg/secring.gpg --decrypt repo/.ci/rultor_secrets.sh.asc
gpg: public key is 9A839C3A
gpg: using subkey 9A839C3A instead of primary key 9AF0FA4C
gpg: using subkey 9A839C3A instead of primary key 9AF0FA4C
gpg: encrypted with 2048-bit RSA key, ID 9A839C3A, created 2014-08-17
      "Rultor.com <gpg@rultor.com>"
gpg: AES256 encrypted data
gpg: original file name='rultor-OCHk'
+ gpg --no-tty --batch --verbose --decrypt --passphrase rultor-key:coala/coala-bears rultor_secrets.sh.enc
gpg: AES encrypted data
gpg: gpg-agent is not available in this session
gpg: encrypted with 1 passphrase
gpg: decryption failed: bad key
'cid' file is absent, container wasn't started correctly

Makman2 · 2017-12-17T14:20:58Z

@gitmate-bot rebase

gitmate-bot · 2017-12-17T14:21:00Z

Hey! This pull request is being rebased automatically. Please DO NOT push while rebase is in progress or your changes would be lost!

gitmate-bot · 2017-12-17T14:21:11Z

Automated rebase was successful!

Makman2 · 2017-12-17T15:21:05Z

temporary build problem, PR is still approved.

RaiVaibhav · 2017-12-17T15:26:26Z

reack 30c55f8

Makman2 · 2017-12-17T23:49:36Z

hmm that's bad... I wanted to make this PR appear in the approved-list... anyway, keeping the tab open so I won't forget

This updates dennis to 0.9 and reverts #1282 It also removes click as an explicit dependency Fixes #1284

Makman2 · 2017-12-18T02:27:04Z

@gitmate-bot rebase

gitmate-bot · 2017-12-18T02:27:05Z

Hey! This pull request is being rebased automatically. Please DO NOT push while rebase is in progress or your changes would be lost!

gitmate-bot · 2017-12-18T02:27:16Z

Automated rebase was successful!

gitmate-bot added process/pending review size/XS labels Oct 21, 2017

nvzard suggested changes Oct 24, 2017

View reviewed changes

gitmate-bot added difficulty/low importance/high status/blocked status/STALE upstream labels Oct 25, 2017

RaiVaibhav suggested changes Nov 11, 2017

View reviewed changes

co-robo added process/wip and removed process/pending review labels Nov 13, 2017

gitmate-bot added process/approved and removed status/STALE process/approved labels Nov 16, 2017

gitmate-bot added process/pending review status/STALE labels Nov 16, 2017

gitmate-bot added process/approved and removed status/STALE process/pending review labels Nov 16, 2017

jayvdb mentioned this pull request Nov 16, 2017

rultor fails to merge coala/coala#4876

Closed

Makman2 removed the process/wip label Nov 16, 2017

jayvdb mentioned this pull request Nov 20, 2017

gpg: decryption failed: bad key yegor256/rultor#1221

Open

gitmate-bot added the status/STALE label Nov 25, 2017

Makman2 removed the status/blocked label Dec 17, 2017

gitmate-bot removed the status/STALE label Dec 17, 2017

gitmate-bot added process/pending review status/blocked and removed process/approved labels Dec 17, 2017

Makman2 added process/approved and removed status/blocked process/pending review labels Dec 17, 2017

gitmate-bot removed the process/approved label Dec 17, 2017

dennis: Update dennis to 0.9

ac3f469

This updates dennis to 0.9 and reverts #1282 It also removes click as an explicit dependency Fixes #1284

gitmate-bot added process/pending review status/blocked process/approved and removed process/pending review process/approved labels Dec 18, 2017

Makman2 merged commit ac3f469 into coala:master Dec 18, 2017

gitmate-bot added the process/approved label Dec 18, 2017

gitmate-bot removed the process/approved label Oct 14, 2018

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Update dennis to 0.9 #2077

Update dennis to 0.9 #2077

Trojan295 commented Oct 21, 2017 •

edited

nvzard left a comment

RaiVaibhav Nov 11, 2017 •

edited

RaiVaibhav Nov 11, 2017

jayvdb Nov 16, 2017

jayvdb Nov 16, 2017

jayvdb commented Nov 16, 2017

RaiVaibhav commented Nov 16, 2017

jayvdb commented Nov 16, 2017

gitmate-bot commented Nov 16, 2017

gitmate-bot commented Nov 16, 2017

jayvdb commented Nov 16, 2017

jayvdb commented Nov 16, 2017

rultor commented Nov 16, 2017

rultor commented Nov 16, 2017

rultor commented Nov 17, 2017

Makman2 commented Dec 17, 2017

gitmate-bot commented Dec 17, 2017

gitmate-bot commented Dec 17, 2017

Makman2 commented Dec 17, 2017

RaiVaibhav commented Dec 17, 2017 •

edited

Makman2 commented Dec 17, 2017

Makman2 commented Dec 18, 2017

gitmate-bot commented Dec 18, 2017

gitmate-bot commented Dec 18, 2017

Update dennis to 0.9 #2077

Update dennis to 0.9 #2077

Conversation

Trojan295 commented Oct 21, 2017 • edited

nvzard left a comment

Choose a reason for hiding this comment

RaiVaibhav Nov 11, 2017 • edited

Choose a reason for hiding this comment

RaiVaibhav Nov 11, 2017

Choose a reason for hiding this comment

jayvdb Nov 16, 2017

Choose a reason for hiding this comment

jayvdb Nov 16, 2017

Choose a reason for hiding this comment

jayvdb commented Nov 16, 2017

RaiVaibhav commented Nov 16, 2017

jayvdb commented Nov 16, 2017

gitmate-bot commented Nov 16, 2017

gitmate-bot commented Nov 16, 2017

jayvdb commented Nov 16, 2017

jayvdb commented Nov 16, 2017

rultor commented Nov 16, 2017

rultor commented Nov 16, 2017

rultor commented Nov 17, 2017

Makman2 commented Dec 17, 2017

gitmate-bot commented Dec 17, 2017

gitmate-bot commented Dec 17, 2017

Makman2 commented Dec 17, 2017

RaiVaibhav commented Dec 17, 2017 • edited

Makman2 commented Dec 17, 2017

Makman2 commented Dec 18, 2017

gitmate-bot commented Dec 18, 2017

gitmate-bot commented Dec 18, 2017

Trojan295 commented Oct 21, 2017 •

edited

RaiVaibhav Nov 11, 2017 •

edited

RaiVaibhav commented Dec 17, 2017 •

edited