Add python 3.3 to python and allow_failures #148

[graingert]

No description provided.

[graingert]

Don't merge this until unittest2 problems are solved

[graingert]

The skip_if function was taken from the MIT licensed https://github.com/eventlet/eventlet/blob/master/tests/__init__.py

In my opinion not a "significant portion of the code"

[willkg]

We're already using nose and we only need a skip_if that takes a boolean. Something like this is probably better:

from functools import wraps

from nose.plugins.skip import SkipTest


def skip_if(condition):
    """Skips tests if condition is True.
    """
    def skipped_wrapper(func):
        @wraps(func)
        def wrapped(*args, **kwargs):
            if condition:
                def skip_function(*args, **kwargs):
                    raise SkipTest()
                return skip_function
            return func(*args, **kwargs)
        return wrapped
    return skipped_wrapper

I haven't tested that, but the gist is there and it's in the style of the rest of django-browserid.

[willkg]

This is awesome work! I'm really psyched about supporting python 3.3 and I'm glad someone else is doing it because I just haven't had time, yet.

[graingert]

It looks like with @willkg's change only 45 tests are run even under django 1.5 (not 47 as expected)

It's also broken with my skip_if fix, looks like it breaks classes

[willkg]

This might need to be:

if condition:
    raise SkipTest()
return func(*args, **kwargs)

[graingert]

Woo, now we support Python 3.3! (at least on paper)

[Osmose]

This looks good to me, if @willkg agrees I'll merge this in. :D

@graingert Oh yeah, can you add 3.3 back in as an allowed failure? I want to have at least one release with it as an allowed failure before I make it mandatory.

[willkg]

Super sorry about not seeing this until just now. I'll check it out tomorrow.

[willkg]

What's this line for? django-nose is already in requirements.txt.

[graingert]

That's because django-nose by default does not support py3k, I'll add this to requirements.txt instead

[willkg]

Oh, hrm... It'd be better if we were using a released version of django-nose. Erik maintains django-nose. It's probably a good idea to push python 3 support in there. Having said that, I just remembered that "go through the django-nose python 3 support patches" is in my queue of things to do. :(

I don't think it should get added to requirements.txt since it's not something you need to have installed to use django-browserid. We should have a requirements-dev.txt file which has development-centric things in it.

[graingert]

requirements.txt only has extra stuff for dev, as the setup.py has the
install_requires

Thomas Grainger

On 10 May 2013 15:14, Will Kahn-Greene notifications@github.com wrote:

In .travis.yml:

install:

• • pip install -e git+git://github.com/sobotklp/django-nose@b3f485e914965e0a7b7012c309864d6a6dcac3ed#egg=django-nose

Oh, hrm... It'd be better if we were using a released version of
django-nose. Erik maintains django-nose. It's probably a good idea to push
python 3 support in there. Having said that, I just remembered that "go
through the django-nose python 3 support patches" is in my queue of things
to do. :(

I don't think it should get added to requirements.txt since it's not
something you need to have installed to use django-browserid. We should
have a requirements-dev.txt file which has development-centric things in it.

—
Reply to this email directly or view it on GitHubhttps://github.com//pull/149/files#r4171394
.

[willkg]

Ahh... ok. This is different than all the other projects I work on--but that's fine. Awesome!

I'll get to the django-nose stuff next week. Whenever that settles out, I'll do a PR to update django-browserid.

[willkg]

I can't seem to get a functional python3.3 virtual environment set up for some reason.

I mentioned a few nits some of which should get fixed while others are subjective. Other than that, it looks ok to me.

[Osmose]

Merged in ee8a1e3. Nice job, @graingert ! 👍