Accidental config mutating bug #52
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
Flimm
force-pushed
the
accidental-config-mutating-bug
branch
2 times, most recently
from
bef5b74
to
c6d49e8
Compare
The decorators would accidentally mutate config, causing future requests against other views to return the wrong policy. This fixes that.
Flimm
force-pushed
the
accidental-config-mutating-bug
branch
from
c6d49e8
to
4673929
Compare
|
There you go. I rebased on master and force pushed to this branch. |
|
Thanks a lot for the rebase and update! 🍰 🌟 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The decorators would accidentally mutate config, causing future requests against other views to return the wrong policy.
This fixes that, and it includes tests. This builds upon code in pull request #51 , so merging this will merge both.