Fix bug when @csp arguments were strings #51

Flimm · 2016-02-12T14:00:29Z

The bug was causing this code:

@csp(IMG_SRC='imgsrv2.com')
def view(request):
     # ....

to emit headers like Content-Security-Policy: img-src i m g s r v 2 . c o m

I fixed the bug, and I changed the documentation to instruct users to use lists or tuples for consistency
with the configuration.

In documentation, instruct users to use lists or tuples for consistency with the configuration.

muffinresearch · 2016-04-13T17:04:42Z

csp/tests/test_decorators.py

+        eq_(response._csp_config,
+            {'img-src': ['foo.com'], 'font-src': ['bar.com']})
+        mw.process_response(REQUEST, response)
+        eq_(policy_list, ["font-src bar.com", "img-src foo.com"])


policy_list is not defined here and it's causing the test to fail.

muffinresearch · 2016-04-13T17:05:34Z

@Flimm Would you be able to fixup the test failure?

Flimm · 2016-04-14T10:29:24Z

Sorry, I'm not sure how I missed that. It's fixed now.

muffinresearch · 2016-04-21T17:55:47Z

Thanks @Flimm

Fix bug when @csp arguments were strings

d81989e

In documentation, instruct users to use lists or tuples for consistency with the configuration.

Flimm mentioned this pull request Feb 12, 2016

Accidental config mutating bug #52

Merged

muffinresearch reviewed Apr 13, 2016
View reviewed changes

Fix test test_csp

e0d7752

EnTeQuAk merged commit 2ba139a into mozilla:master Apr 21, 2016

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fix bug when @csp arguments were strings #51

Fix bug when @csp arguments were strings #51

Flimm commented Feb 12, 2016

muffinresearch Apr 13, 2016

muffinresearch commented Apr 13, 2016

Flimm commented Apr 14, 2016

muffinresearch commented Apr 21, 2016

Fix bug when @csp arguments were strings #51

Fix bug when @csp arguments were strings #51

Conversation

Flimm commented Feb 12, 2016

muffinresearch Apr 13, 2016

Choose a reason for hiding this comment

muffinresearch commented Apr 13, 2016

Flimm commented Apr 14, 2016

muffinresearch commented Apr 21, 2016