Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Avoid subtraction underflow with line records #528

Merged
merged 1 commit into from
Jan 9, 2023
Merged

Avoid subtraction underflow with line records #528

merged 1 commit into from
Jan 9, 2023

Conversation

mstange
Copy link
Collaborator

@mstange mstange commented Jan 6, 2023

Fixes #527.

@mstange mstange self-assigned this Jan 6, 2023
@mstange mstange force-pushed the fix-line-record-length-subtraction-underflow branch from 53d1784 to 7578a23 Compare January 6, 2023 22:43
gabrielesvelto
gabrielesvelto approved these changes Jan 9, 2023
View reviewed changes
Copy link
Collaborator

@gabrielesvelto gabrielesvelto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for fixing this

@gabrielesvelto gabrielesvelto merged commit 0bd3a3d into mozilla:main Jan 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gabrielesvelto gabrielesvelto gabrielesvelto approved these changes

Assignees

@mstange mstange

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

A panic occured
2 participants
@mstange @gabrielesvelto