Fix Bug 936492, implement tree selector for multi tree support #210
Conversation
I can no longer click the search field to focus it. It immediately defocuses. |
oops, fixing. |
The Switch Tree menu is missing on results pages. There, it should run the same search against any tree you select. It does appear in file views, but selecting a different tree takes you to a browse view of the root of the tree. It should take you to a parallel file in the new tree, if one exists. (Otherwise, the browse-the-root behavior is correct.) You will likely need some back-end support for all of this. I am happy to contribute. |
The first case should be fine. The second however, there will definitely have to be some backend logic and your contribution will be much appreciated. |
Remember, the search template is used only when someone actually hits Return. So the search selector still doesn't show up for any live searches. |
Also, we need to preserve the checked state of the Case Sensitive checkbox when we choose a new tree from a search-results page. |
Remember to leave space for tree descriptions in the dropdowns. You can put placeholder text there for now. |
Awesome, thanks for all of the feedback. I will continue on this one first thing in the morning and we can sync up when you are online. |
If you can make the tree selector menu items on files and directory views link to /some_tree/parallel/what/ever/dir/or/file, I can write a "parallel" controller on the backend that redirects to a parallel dir or file if there is one (and otherwise to the root). |
When I'm at http://33.33.33.77:8000/code2/source/main.c, the tree menu item points to /code/parallel/. It should point to /code/parallel/main.c. |
And I suppose the currently selected item shouldn't even be a link. |
On number one, I know why that is happening and on number 2, we can do that, let me look. |
Parallel links look good!
|
r+. Let's merge that baby in! |
I added https://bugzilla.mozilla.org/show_bug.cgi?id=951462 for backend support for the tree descriptions. |
\o/ |
Fix Bug 936492, implement tree selector for multi tree support
@erikrose r?