Skip to content
This repository has been archived by the owner on Oct 13, 2021. It is now read-only.

Fix Bug 936492, implement tree selector for multi tree support #210

Merged
8 commits merged into from Dec 18, 2013
Merged

Fix Bug 936492, implement tree selector for multi tree support #210

8 commits merged into from Dec 18, 2013

Conversation

ghost
Copy link

@ghost ghost commented Dec 16, 2013

@erikrose
Copy link
Contributor

I can no longer click the search field to focus it. It immediately defocuses.

@ghost
Copy link
Author

ghost commented Dec 16, 2013

oops, fixing.

@erikrose
Copy link
Contributor

The Switch Tree menu is missing on results pages. There, it should run the same search against any tree you select.

It does appear in file views, but selecting a different tree takes you to a browse view of the root of the tree. It should take you to a parallel file in the new tree, if one exists. (Otherwise, the browse-the-root behavior is correct.)

You will likely need some back-end support for all of this. I am happy to contribute.

@ghost
Copy link
Author

ghost commented Dec 16, 2013

The first case should be fine. The second however, there will definitely have to be some backend logic and your contribution will be much appreciated.

@erikrose
Copy link
Contributor

Remember, the search template is used only when someone actually hits Return. So the search selector still doesn't show up for any live searches.

@erikrose
Copy link
Contributor

Also, we need to preserve the checked state of the Case Sensitive checkbox when we choose a new tree from a search-results page.

@erikrose
Copy link
Contributor

Remember to leave space for tree descriptions in the dropdowns. You can put placeholder text there for now.

@ghost
Copy link
Author

ghost commented Dec 16, 2013

Awesome, thanks for all of the feedback. I will continue on this one first thing in the morning and we can sync up when you are online.

@erikrose
Copy link
Contributor

If you can make the tree selector menu items on files and directory views link to /some_tree/parallel/what/ever/dir/or/file, I can write a "parallel" controller on the backend that redirects to a parallel dir or file if there is one (and otherwise to the root).

@erikrose
Copy link
Contributor

When I'm at http://33.33.33.77:8000/code2/source/main.c, the tree menu item points to /code/parallel/. It should point to /code/parallel/main.c.

@erikrose
Copy link
Contributor

And I suppose the currently selected item shouldn't even be a link.

@ghost
Copy link
Author

ghost commented Dec 17, 2013

On number one, I know why that is happening and on number 2, we can do that, let me look.

@erikrose
Copy link
Contributor

Parallel links look good!

  • The switcher menu on search-results pages has no tree descriptions.
  • The currently selected tree is still a link.

@erikrose
Copy link
Contributor

r+. Let's merge that baby in!

@erikrose
Copy link
Contributor

I added https://bugzilla.mozilla.org/show_bug.cgi?id=951462 for backend support for the tree descriptions.

@ghost
Copy link
Author

ghost commented Dec 18, 2013

\o/

ghost pushed a commit that referenced this pull request Dec 18, 2013
Fix Bug 936492, implement tree selector for multi tree support
@ghost ghost merged commit 43e9f86 into mozilla:ui Dec 18, 2013
@ghost ghost deleted the multi-tree branch December 18, 2013 10:29
This pull request was closed.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant