fixes bug 713909 - [tinder] generateLog should raise better errors on…

… missing files, r=Pike

apps/tinder/tests.py

@@ -16,7 +16,7 @@
 from django.test.client import Client
 from mbdb.models import (Build, Change, Master, Log, Property, SourceStamp,
                          Builder, Slave)
-from tinder.views import _waterfall
+from tinder.views import _waterfall, LogMountKeyError
 from tinder.templatetags import build_extras
 
 
@@ -319,6 +319,24 @@ def test_showlog(self):
         ok_('<span class="pre stderr">stderr content\n</span>' in content)
         ok_('json' not in content)
 
+    def test_showlog_invalid_master(self):
+        master = Master.objects.all()[0]
+
+        build = Build.objects.all()[0]
+        step = build.steps.all()[0]
+        log = Log.objects.create(
+          name='foo',
+          filename='foo.log',
+          step=step,
+        )
+        url = reverse('tinder.views.showlog',
+                      args=[master.name, log.filename])
+        self.assertRaises(
+            LogMountKeyError,
+            self.client.get,
+            url
+        )
+
     def test_render_tbpl(self):
         url = reverse('tinder.views.tbpl')
         response = self.client.get(url)

apps/tinder/views.py

@@ -30,6 +30,10 @@
 resultclasses = ['success', 'warning', 'failure', 'skip', 'except']
 
 
+class LogMountKeyError(Exception):
+    pass
+
+
 def debug_(*msg):
     if False:
         print ' '.join(msg)
@@ -703,7 +707,10 @@ def generateLog(master, filename):
     try:
         base = settings.LOG_MOUNTS[master]
     except KeyError:
-        raise Http404("Master `%s` not found" % master)
+        raise LogMountKeyError(
+            'The log mount %r is not in settings.LOG_MOUNTS'
+            % master
+        )
     head = re.compile('(\d+):(\d)')
     f = None
     filename = os.path.join(base, filename)