Skip to content
This repository has been archived by the owner on Jun 12, 2021. It is now read-only.

Commit

Permalink
bug 658656, fix comments
Browse files Browse the repository at this point in the history
  • Loading branch information
Pike committed Feb 7, 2014
1 parent c5d95c0 commit ed3330a
Showing 1 changed file with 6 additions and 5 deletions.
11 changes: 6 additions & 5 deletions apps/shipping/views/signoff.py
Expand Up @@ -172,9 +172,10 @@ def annotated_pushes(self,
else:
# This is the first load whereby we want to select all pushes up
# to a certain cutoff.
# All pushes in our query count
pushes_left = pushes_q.distinct().count()
cutoff_dates = []
pushes_left = (pushes_q
.distinct()
.count()) # count pushes for this appversion
cutoff_dates = [] # sign-off push dates, oldest is of interest
action4id = dict((a.id, a) for a in actions)

if Action.ACCEPTED in flags:
Expand All @@ -191,8 +192,8 @@ def annotated_pushes(self,
if Action.REJECTED in flags:
a = action4id[flags[Action.REJECTED]]
cutoff_dates.append(a.signoff.push.push_date)
# only add this signoff to initial_diff if we don't already have
# an ACCEPTED and a PENDING signoff
# only add this signoff to initial_diff if we don't already
# have an ACCEPTED and a PENDING signoff
if len(initial_diff) < 2:
initial_diff.append(a.signoff_id)

Expand Down

0 comments on commit ed3330a

Please sign in to comment.