Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Circle builds not running for a contributor's PR #577

Closed
muffinresearch opened this issue Mar 6, 2020 · 5 comments
Closed

Circle builds not running for a contributor's PR #577

muffinresearch opened this issue Mar 6, 2020 · 5 comments

Comments

@muffinresearch
Copy link
Contributor

muffinresearch commented Mar 6, 2020

Historically we've had no issues with Circle running on PRS. But two branches for a contributor are stuck with the following message:

Matrix_Room_Manifestation_by_grlwholifts_·_Pull_Request__571_·_mozilla_extension-workshop

Here's an example of two branches that didn't fire a build:

The only way I could get circle to build the latest rev was to push a PR of a copy of the same branch.

The webhooks for the PRs appear to have been fired OK. Also adding new commits didn't result in any change to the build status.

The earlier branch for #569 uses a branch called master so maybe that's related in some way? That said the remaining branch that is still stuck, isn't called master (but it does contain revisions that are from the previous branch).

/cc @bqbn

@muffinresearch muffinresearch changed the title Issues with Circle builds not running for a contributors PR Issues with Circle builds not running for a contributor's PR Mar 6, 2020
@muffinresearch muffinresearch changed the title Issues with Circle builds not running for a contributor's PR Circle builds not running for a contributor's PR Mar 6, 2020
@bqbn
Copy link
Collaborator

bqbn commented Mar 6, 2020

I can't seem to be able to reproduce the issue. I filed a test PR #578, which trigger a build in CircleCI without problem (https://circleci.com/gh/mozilla/extension-workshop/tree/pull%2F578).

The github log shows the webhook for #571 was fired and received 200,

Screen Shot 2020-03-06 at 3 26 43 PM

However I can't find a build for #571 in the CircleCI console.

Another piece of difference I notice is that for my PR, there were a few status calls to CircleCI after the initial pull_request call, whereas PR #571 only had the initial pull_request call, but no subsequent status calls.

@muffinresearch
Copy link
Contributor Author

muffinresearch commented Mar 9, 2020

@bqbn would be interesting to try this again with an account with no permissions. I'll see if I can try that today.

@muffinresearch-test
Copy link

See also #587

@muffinresearch-test
Copy link

See also #588 (branch is master)

@muffinresearch
Copy link
Contributor Author

I can't seem to be able to reproduce the issue. I filed a test PR #578, which trigger a build in CircleCI without problem (https://circleci.com/gh/mozilla/extension-workshop/tree/pull%2F578).

The github log shows the webhook for #571 was fired and received 200,

Screen Shot 2020-03-06 at 3 26 43 PM

However I can't find a build for #571 in the CircleCI console.

Another piece of difference I notice is that for my PR, there were a few status calls to CircleCI after the initial pull_request call, whereas PR #571 only had the initial pull_request call, but no subsequent status calls.

@bqbn I concur with not being able to repro. I think we can just close this out and see if it comes up again.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants