Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Matrix Room Manifestation #571

Merged
merged 23 commits into from Mar 9, 2020
Merged

Conversation

grlwholifts
Copy link
Contributor

Fixes #564

cc: @bjherbison

@caitmuenster caitmuenster self-requested a review March 3, 2020 00:11
community.md Outdated Show resolved Hide resolved
Copy link
Collaborator

@championshuttler championshuttler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@muffinresearch link is not working can you please use this one

4. If you have any problems, contact us on the [dev-addons mailing list](https://mail.mozilla.org/listinfo/dev-addons) or [Add-ons](https://mzl.la/2u8ZGbg) channel on [Matrix](https://wiki.mozilla.org/Matrix).

community.md Outdated Show resolved Hide resolved
community.md Outdated Show resolved Hide resolved
community.md Show resolved Hide resolved
@muffinresearch
Copy link
Contributor

@caitmuenster this probably won't build by itself, when it's ready to land let me know and I'll re-push to check the build passes.

@grlwholifts
Copy link
Contributor Author

@caitmuenster @championshuttler I'm not sure why the links keep getting shortened to bit.ly, whereas in my local machine, they look original. Should I use web editor for this?

@championshuttler
Copy link
Collaborator

No we need to use shortened links only as longer links are not working with Jekyll

community.md Outdated Show resolved Hide resolved
Copy link
Contributor

@muffinresearch muffinresearch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@muffinresearch muffinresearch merged commit 03bc21c into mozilla:master Mar 9, 2020
@grlwholifts grlwholifts deleted the matrixroom branch March 10, 2020 07:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Mention Matrix manifestation
4 participants