doc: Added entry for run command option profile-create-new-if-missing #832
Conversation
|
Hi @rpl: |
There was a problem hiding this comment.
@akhilpanchal apologies for letting you wait that much on this PR, I have been away for a week and just got back.
The description of the new option is technically right, I just suggested some small tweaks to make it a bit more consistent with the description of the --keep-profile-changes option.
Let me know what do you think about the tweaks I did suggest in the inline comment below.
@caitmuenster would you mind to also review this from an editorial perspective after I've marked it as approved?
| This option is to be used with `--firefox-profile` or `--chromium-profile`. With this option, the profile option provided will be treated as a directory path and if the directory does not exist, it will be created. | ||
|
|
||
| Environment variable: `$WEB_EXT_PROFILE_CREATE_IF_MISSING` | ||
|
|
There was a problem hiding this comment.
Nit, how about tweaking this description a bit to make it consistent with the --keep-profile-changes option that follows? e.g. something like:
With this option, the profile directory (specified by the `--firefox-profile` or `--chromium-profile` options) will be created if it does not exist yet.
::: note alert
When this option is specified the `--firefox-profile` option is always treated as a directory path.
:::
Environment variable: `$WEB_EXT_PROFILE_CREATE_IF_MISSING`
There was a problem hiding this comment.
Definitely! This is more concise and clear.
|
Thanks so much for the patch, @akhilpanchal! This looks good from an editorial perspective. |
There was a problem hiding this comment.
@akhilpanchal Thanks a lot for following up the web-ext pull request by also updating the docs! ❤️
| last_updated_by: noraj | ||
| date: 2020-10-11 18:11:47 | ||
| last_updated_by: akhilpanchal | ||
| date: 2020-11-15 12:46:15 |
There was a problem hiding this comment.
Nit, we may update the date before merging (not strictly mandatory to be fair)
There was a problem hiding this comment.
Hmm -- I'll go ahead and update it to reflect the next deploy date of Dec 03.
|
Hey @akhilpanchal, I wanted to follow up with you but unfortunately couldn't find your contact information. :( I would love to send you some stickers as a small token of appreciation for your recent contributions! Would you mind sending me an email at cneiman [at] mozilla [dot] com with your current mailing address? |
@rpl
Doc entry for web-ext run command option
--profile-create-new-if-missing. Follow up to web-ext pull request.Please let me know if I have missed something.