This repository has been archived by the owner on May 28, 2019. It is now read-only.
Fix bug 904281: Add more ways to see stats about votes to the admin. #257
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds a few niceties to the admin interface to make it easier to find information about how many votes there are, who has voted, what they have voted on, etc. There's no tests because admin stuff is in general hard to test and the set of users for this stuff is small and limited to trusted individuals. The only testable thing here is the admin filter, but it's trivial and doesn't handle any edge cases.
| @@ -148,6 +148,8 @@ class Vote(models.Model, CachingMixin): | |||
| user = models.ForeignKey(User) | |||
| video = models.ForeignKey(Video2013) | |||
|
|
|||
| created = models.DateTimeField(default=datetime.now) | |||
There was a problem hiding this comment.
Nope. Completely forgot. Doh!
|
It's mostly admin wizardry, which I'm assuming you've tested locally and work the way you want. I've not done that, but the code and style look good. I didn't check the rest of the app, but I guess you're not using the timezone stuff and storing UTC datetimes at present. That'd be good to do in future, but if you're not doing it now probably best for next year. If you are doing it, then you should use the more appropriate method for the default in the Unless there's work for the timezone stuff, it's an r+ from me. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a few niceties to the admin interface to make it easier to find
information about how many votes there are, who has voted, what they
have voted on, etc.
There's no tests because admin stuff is in general hard to test and
the set of users for this stuff is small and limited to trusted
individuals. The only testable thing here is the admin filter, but it's
trivial and doesn't handle any edge cases.