Record engine error in telemetry (#68)

mozilla · Feb 3, 2022 · c40f707 · c40f707
1 parent 03146fc
commit c40f707
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 4 deletions.
diff --git a/extension/controller/translation/translationWorker.js b/extension/controller/translation/translationWorker.js
@@ -537,8 +537,15 @@ class TranslationHelper {
                 input.push_back(sourceParagraph);
             });
 
-            // translate the input, which is a vector<String>; the result is a vector<Response>
-            let result = this.translationService.translate(translationModel, input, responseOptions);
+            let result = null;
+            try {
+                // translate the input, which is a vector<String>; the result is a vector<Response>
+                result = this.translationService.translate(translationModel, input, responseOptions);
+            } catch (e) {
+                console.error("Error in translation engine ", e)
+                postMessage(["onError", "marian"]);
+                throw e;
+            }
 
             const translatedParagraphs = [];
             for (let i = 0; i < result.size(); i+=1) {

diff --git a/extension/mediator.js b/extension/mediator.js
@@ -171,8 +171,6 @@ class Mediator {
             case "onError":
                 // payload is a metric name from metrics.yaml
                 this.telemetry.increment("errors", message.payload);
-                // submit errors ping right away assuming the rest of experience is broken
-                this.telemetry.submit("custom")
                 break;
 
             case "onModelEvent":