Skip to content
This repository has been archived by the owner on Sep 4, 2023. It is now read-only.

Content classification per item in the translation batch #94

Closed
andrenatal opened this issue Feb 10, 2022 · 1 comment · Fixed by #111
Closed

Content classification per item in the translation batch #94

andrenatal opened this issue Feb 10, 2022 · 1 comment · Fixed by #111
Assignees
@abhi-agg
Labels
bug Something isn't working
Milestone
W3

Comments

@andrenatal
Copy link
Contributor

andrenatal commented Feb 10, 2022 •
edited by abhi-agg
Loading

We need to be able to identify if the string content is text or html individually here and have one ResponseOption per input item in the batch instead to the entire request.

The corresponding issue tracking this feature in engine: browsermt/bergamot-translator#345
@andrenatal andrenatal added the bug Something isn't working label Feb 10, 2022
@andrenatal andrenatal added this to the W2 milestone Feb 10, 2022
@jerinphilip jerinphilip mentioned this issue Feb 10, 2022
Merged
jerinphilip added a commit to browsermt/bergamot-translator that referenced this issue Feb 11, 2022
@jerinphilip @jelmervdl
Allow per-input options (#346)
ec46919 
Changes signature of BlockingService::{translate,pivot}Multiple
functions to take per input options, so a mix of HTML and plaintext
can be sent from the extension. Templating over testing is adjusted
to allow for continuous evaluations by modifying the test code.

Updates WebAssembly bindings to reflect the change in signature
and the javascript test-page to work with the new bindings.

This change lacks an accompanying test specific to the mixed HTML
and plaintext inputs.

Fixes: #345
See also: mozilla/firefox-translations#94
Co-authored-by: Jelmer van der Linde <jelmer@ikhoefgeen.nl>
@andrenatal andrenatal modified the milestones: W2, W3 Feb 19, 2022
@abhi-agg
Copy link
Collaborator

This is closed via #111.

@abhi-agg abhi-agg linked a pull request Feb 21, 2022 that will close this issue
Update bergamot translator to v0.4.1 #111
Merged
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@abhi-agg abhi-agg

Labels
bug Something isn't working
Projects
None yet
Milestone
W3
Development

Successfully merging a pull request may close this issue.

Update bergamot translator to v0.4.1 abhi-agg/firefox-translations
2 participants
@andrenatal @abhi-agg