This repository has been archived by the owner on Sep 4, 2023. It is now read-only.
Update bergamot translator to v0.4.1 #111
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Removed "await" keyword at the callsite
- Imported all api changes pertaining to bergamot translator engine
|
@andrenatal I had to change the input string (please see this commit) that is being used for testing. I am not sure whether the final sentence is a valid Spanish sentence or not. I had to change the expected output as well. Basically, I translated the Spanish sentence to English in the wasm test page and used the translated sentences as the expected result in the test. |
- Changed input Spanish sentence and modified the expected result as well
abhi-agg
force-pushed
the
update-bergamot-translator
branch
from
2928731
to
4ad83b9
Compare
|
Hi @abhi-agg , it is valid semantically. I will review your patch later today. Is it ready to land? |
|
Great. Thanks. Yes, it is ready to land from my side. |
andrenatal
approved these changes
Feb 19, 2022
This was
linked to
issues
Feb 21, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Manual Tests done: