show back to app link on tablet (bug 1127330)

mozilla · Jan 30, 2015 · ca2ac87 · ca2ac87
1 parent e52381a
commit ca2ac87
Show file tree

Hide file tree

Showing 3 changed files with 47 additions and 14 deletions.
diff --git a/src/media/css/typography.styl b/src/media/css/typography.styl
@@ -103,6 +103,16 @@ dd {
 
 .back-to-app {
     display: none;
+
+    &:before {
+        content: "\2039";
+        display: inline-block;
+        font-size: 28px;
+        font-weight: 300;
+        margin-right: 10px;
+        position: relative;
+        top: 3px;
+    }
 }
 
 .prose {
@@ -145,6 +155,9 @@ dd {
 }
 
 @media $base-tablet {
+    .back-to-app {
+        display: inline-block;
+    }
     h1 {
         font-size: 30px;
     }
@@ -159,19 +172,6 @@ dd {
         margin: 48px 0 0;
         padding: 18px 15px;
     }
-    .back-to-app {
-        display: inline-block;
-
-        &:before {
-            content: "\2039";
-            display: inline-block;
-            font-size: 28px;
-            font-weight: 300;
-            margin-right: 10px;
-            position: relative;
-            top: 3px;
-        }
-    }
     .island.prose {
         padding: 24px;
     }

diff --git a/tests/lib/helpers.js b/tests/lib/helpers.js
@@ -257,6 +257,11 @@ function setUpDesktop() {
 }
 
 
+function setUpTablet() {
+    changeViewportTablet();
+}
+
+
 function tearDown() {
     changeViewportMobile();
 }
@@ -271,6 +276,15 @@ function desktopTest(testObj) {
 }
 
 
+function tabletTest(testObj) {
+    // Wrapper around test object to set up tablet viewport.
+    return _.extend(testObj, {
+        setUp: setUpTablet,
+        tearDown: tearDown
+    });
+}
+
+
 module.exports = {
     assertAPICallWasMade: assertAPICallWasMade,
     assertContainsText: assertContainsText,
@@ -288,6 +302,7 @@ module.exports = {
     makeUrl: makeUrl,
     setUpDesktop: setUpDesktop,
     startCasper: startCasper,
+    tabletTest: tabletTest,
     tearDown: tearDown,
     waitForPageLoaded: waitForPageLoaded,
 };
diff --git a/tests/ui/app/reviews.js b/tests/ui/app/reviews.js
@@ -1,7 +1,7 @@
 /*
     Tests for app reviews.
 */
-var helpers = require('../lib/helpers');
+var helpers = require('../../lib/helpers');
 
 function testAddReviewModal(test) {
     casper.waitForSelector('.add-review-form', function() {
@@ -175,3 +175,21 @@ casper.test.begin('Test login to r? if already r? on desktop', helpers.desktopTe
         helpers.done(test);
     }
 }));
+
+
+casper.test.begin('Test reviews page back to app link', helpers.tabletTest({
+    test: function(test) {
+        helpers.startCasper({path: '/app/has_rated/ratings'});
+
+        helpers.waitForPageLoaded(function() {
+            test.assertVisible('.back-to-app');
+            casper.click('.back-to-app');
+        });
+
+        casper.waitForSelector('[data-page-type~="detail"]', function() {
+            test.assertExists('.detail');
+        });
+
+        helpers.done(test);
+    }
+}));